Skip to content

Commit cf44e80

Browse files
committed
LCD issue on 1.8.0 framework
1 parent 8eeca8b commit cf44e80

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

platformio.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
; http://docs.platformio.org/page/projectconf.html
1010

1111
[platformio]
12-
env_default = nodemcuv2-ptc
12+
env_default = nodemcuv2-newui
1313
;env_default = nodemcuv2, nodemcuv2-ptc, oled, thorrax, sonoff, sonoffota, ioexpander
1414

1515
[common_env_data]

src/DisplayLcd.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
#include "Brewpi.h"
2323
#include "DisplayBase.h"
24-
#include "SpiLcd.h"
24+
//#include "SpiLcd.h"
2525
#include "NullLcdDriver.h"
2626

2727
#if BREWPI_IIC_LCD
@@ -37,7 +37,7 @@
3737
typedef IICOledLcd LcdDriver;
3838
#else // BREWPI_OLED128x64_LCD
3939
#if defined(BREWPI_IIC_LCD)
40-
typedef IIClcd LcdDriver;
40+
typedef IIClcd LcdDriver;
4141
#else
4242
#if BREWPI_EMULATE || !BREWPI_LCD || !ARDUINO
4343
typedef NullLcdDriver LcdDriver;

src/IicLcd.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ inline size_t IIClcd::write(uint8_t value) {
295295
if (!_bufferOnly) {
296296
send(value, Rs);
297297
}
298-
return 0;
298+
return 1;
299299
}
300300

301301
/************ low level data pushing commands **********/
@@ -332,10 +332,10 @@ void IIClcd::expanderWrite(uint8_t _data) {
332332

333333
void IIClcd::pulseEnable(uint8_t _data){
334334
expanderWrite(_data | En); // En high
335-
delayMicroseconds(1); // enable pulse must be >450ns
335+
delayMicroseconds(1); //delayMicroseconds(1); // enable pulse must be >450ns
336336

337337
expanderWrite(_data & ~En); // En low
338-
delayMicroseconds(50); // commands need > 37us to settle
338+
delayMicroseconds(50); //delayMicroseconds(50); // commands need > 37us to settle
339339
}
340340

341341
// This resets the backlight timer and updates the SPI output

0 commit comments

Comments
 (0)