Skip to content

fix(bx-dropdown): prevent interactivity while disabled#9881

Merged
kodiakhq[bot] merged 5 commits intocarbon-design-system:mainfrom
andy-blum:fix/bx-dropdown
Jan 10, 2023
Merged

fix(bx-dropdown): prevent interactivity while disabled#9881
kodiakhq[bot] merged 5 commits intocarbon-design-system:mainfrom
andy-blum:fix/bx-dropdown

Conversation

@andy-blum
Copy link
Copy Markdown
Contributor

@andy-blum andy-blum commented Jan 4, 2023

Related Ticket(s)

Closes: #9754

Description

When disabled bx-dropdown is not interactive

Changelog

Changed

  • Fixed bug in bx-dropdown

@andy-blum andy-blum added bug Something isn't working package: carbon web components labels Jan 4, 2023
@andy-blum andy-blum requested a review from a team as a code owner January 4, 2023 15:04
@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Jan 4, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9881/index.html

Built with commit: 339b32a5539d92024b1b4a6236592f663a31fc4e

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Jan 4, 2023 •
edited
Loading

Deploy preview created for package "Carbon Web Components":
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9881/index.html

Built with commit: 339b32a5539d92024b1b4a6236592f663a31fc4e

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Jan 4, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9881/index.html

Built with commit: 339b32a5539d92024b1b4a6236592f663a31fc4e

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Jan 4, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9881/index.html

Built with commit: 339b32a5539d92024b1b4a6236592f663a31fc4e

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Jan 4, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9881/index.html

Built with commit: 339b32a5539d92024b1b4a6236592f663a31fc4e

annawen1
annawen1 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Jan 5, 2023
@kodiakhq kodiakhq bot merged commit 5fe8471 into carbon-design-system:main Jan 10, 2023
@andy-blum andy-blum deleted the fix/bx-dropdown branch February 20, 2023 14:36
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@andy-blum
fix(bx-dropdown): prevent interactivity while disabled (carbon-design…
c9b2b77 
…-system#9881)

### Related Ticket(s)

Closes: carbon-design-system#9754

### Description

When disabled bx-dropdown is not interactive

### Changelog

**Changed**

- Fixed bug in bx-dropdown
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@andy-blum
fix(bx-dropdown): prevent interactivity while disabled (carbon-design…
ca04a0d 
…-system#9881)

### Related Ticket(s)

Closes: carbon-design-system#9754

### Description

When disabled bx-dropdown is not interactive

### Changelog

**Changed**

- Fixed bug in bx-dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annawen1 annawen1 annawen1 approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

No one assigned

Labels

bug Something isn't working package: carbon web components Ready to merge Label for the pull requests that are ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug]: bx-dropdown-item disabled property not working

3 participants

@andy-blum @ibmdotcom-bot @annawen1