Claude/check 3dblox parser 01 kxe aw7 jiu lc nm s bm jm fuwh#3
Merged
cclin0817 merged 2 commits intoNov 20, 2025
Merged
Conversation
Documented 3 bugs and 1 limitation found in the py3dblox parser: - Bug #1: None/null values converted to string "None" - Bug #2: Wildcard paths only work in filename - Bug #3: Missing validation for required non-null values - Limitation: cad_layer field not implemented The most critical issue is Bug #1 which causes data corruption.
…to "None" string After comparing with the C++ reference implementation, identified and fixed one critical bug where YAML null values (~) were being converted to the string "None" instead of being preserved as Python None objects. Changes: - Updated base_parser.py extract_value() to check for None before type conversion - Replaced all str() conversions with extract_value() calls throughout the codebase - Updated Connection type annotations to allow str | None for top/bot fields - Added proper None handling in dbx_parser.py and dbv_parser.py Verified against C++ test expectations (Test3DBloxParser.cpp:111) which confirms that connection->getBottomRegion() should be nullptr when bot: ~. Also clarified in bug report that two other identified issues were NOT bugs: - Wildcard path limitation is consistent with C++ implementation - Null values in "required" fields are intentional per specification All parsers tested successfully with example files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.