fix(grvt): fix watch_orders not receiving updates for symbol-specific…#28462
Closed
Ghraven wants to merge 1 commit into
Closed
fix(grvt): fix watch_orders not receiving updates for symbol-specific…#28462Ghraven wants to merge 1 commit into
Ghraven wants to merge 1 commit into
Conversation
… subscriptions Fixes two bugs reported in ccxt#28455: 1. Message hash mismatch: watch_orders() registered per-symbol hashes as 'order::' + symbol (singular) but handle_order() resolved to 'orders::' + symbol (plural). This caused watch_orders(symbol=X) to hang indefinitely. Fix: align watch_orders to use 'orders::' prefix. 2. Premature filtering in handle_order(): the handler called filter_by_symbol_since_limit before resolving, which could silently drop orders. Fix: resolve the full orders cache directly and let watch_orders' own filter_by_symbol_since_limit handle post-filtering.
Collaborator
Author
|
Thanks for the heads up @carlosmiei! Understood — I wasn't aware PR #28461 was already in flight covering this. Good to know the fix also requires updating the TypeScript source since the Python is transpiled from it. I'll keep that in mind for future contributions to ccxt. Feel free to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… subscriptions
Fixes two bugs reported in #28455:
Message hash mismatch: watch_orders() registered per-symbol hashes as 'order::' + symbol (singular) but handle_order() resolved to 'orders::' + symbol (plural). This caused watch_orders(symbol=X) to hang indefinitely. Fix: align watch_orders to use 'orders::' prefix.
Premature filtering in handle_order(): the handler called filter_by_symbol_since_limit before resolving, which could silently drop orders. Fix: resolve the full orders cache directly and let watch_orders' own filter_by_symbol_since_limit handle post-filtering.