nit pick tests

Author: pcriadoperez

package.json

@@ -33,7 +33,7 @@
     "ws-tests-spot": "mocha ./tests/binance-ws-spot.test.ts --exit",
     "ws-tests-futures": "mocha ./tests/binance-ws-futures.test.ts --exit",
     "ws-api-userdata-tests": "mocha ./tests/binance-ws-api-userdata.test.ts --exit",
-    "ws-live-tests": "mocha ./tests/binance-ws-spot.test.ts ./tests/binance-ws-futures.test.ts ./tests/binance-ws-api-userdata.test.ts --exit",
+    "ws-live-tests": "mocha ./tests/binance-ws-spot.test.ts ./tests/binance-ws-futures.test.ts ./tests/binance-ws-api-userdata.test.ts ./tests/binance-ws-api-ticker.test.ts --exit",
     "test-debug": "mocha --inspect-brk",
     "lint": "eslint src/",
     "cover": "istanbul cover _mocha --report lcovonly",

src/node-binance-api.ts

@@ -1554,11 +1554,22 @@ export default class Binance {
 
         ws.on('open', () => {
             if (this.Options.verbose) this.Options.log('WebSocket API: Connected to ' + this.getWsApiUrl());
-            this.handleSocketOpen(ws, null);
+            (ws as any).isAlive = true;
+        });
+        ws.on('pong', () => { (ws as any).isAlive = true; });
+        ws.on('error', (err) => {
+            this.Options.log('WebSocket API error: ' + (ws as any).connectionId + ' error: ' + err.message);
+        });
+        ws.on('close', (code, reason) => {
+            if (this.Options.verbose) this.Options.log('WebSocket API closed: ' + (ws as any).connectionId +
+                (code ? ' (' + code + ')' : '') +
+                (reason ? ' ' + reason : ''));
+            delete this.wsApiConnections[connectionId];
+            if ((ws as any).reconnect && typeof reconnect === 'function') {
+                if (this.Options.verbose) this.Options.log('WebSocket API reconnecting: ' + connectionId);
+                reconnect();
+            }
         });
-        ws.on('pong', this.handleSocketHeartbeat.bind(this, ws));
-        ws.on('error', this.handleSocketError.bind(this, ws));
-        ws.on('close', this.handleSocketClose.bind(this, ws, reconnect));
         ws.on('message', data => {
             try {
                 if (this.Options.verbose) this.Options.log('WebSocket API data:', data);
@@ -1659,9 +1670,10 @@ export default class Binance {
         delete this.wsApiConnections[connectionId];
 
         // Reject all pending requests for this connection
-        for (const requestId in this.wsApiPendingRequests) {
+        const pendingIds = Object.keys(this.wsApiPendingRequests);
+        for (const requestId of pendingIds) {
             const pending = this.wsApiPendingRequests[requestId];
-            if (pending.connectionId === connectionId) {
+            if (pending && pending.connectionId === connectionId) {
                 pending.reject(new Error('WebSocket API connection terminated'));
             }
         }

tests/binance-ws-api-userdata.test.ts

@@ -510,24 +510,32 @@ describe('WebSocket API Live Tests', function () {
             let executionReceived = false;
             let balanceReceived = false;
             let subscriptionReady = false;
+            let finished = false;
+
+            const finish = (err?: Error) => {
+                if (finished) return;
+                finished = true;
+                stopWsApiConnections(true);
+                if (err) return done(err);
+                done();
+            };
+
+            const checkCompletion = () => {
+                if (executionReceived && balanceReceived && subscriptionReady) {
+                    console.log('Both execution and balance events received!');
+                    setTimeout(() => finish(), 2000);
+                }
+            };
 
             binance.websockets.userData(
                 (data) => {
                     // All updates callback
                     console.log('Event received:', data.e, data);
-
-                    // Check if we received both events
-                    if (executionReceived && balanceReceived && subscriptionReady) {
-                        console.log('✅ Both execution and balance events received!');
-                        setTimeout(() => {
-                            stopWsApiConnections(true);
-                            done();
-                        }, 2000);
-                    }
+                    checkCompletion();
                 },
                 (balance) => {
                     // Balance callback
-                    console.log('📊 Balance update received:', balance);
+                    console.log('Balance update received:', balance);
                     balanceReceived = true;
 
                     assert(balance !== null, WARN_SHOULD_BE_NOT_NULL);
@@ -548,18 +556,11 @@ describe('WebSocket API Live Tests', function () {
                         assert(Array.isArray(balance.B), 'Balances should be an array');
                     }
 
-                    // Check if both events received
-                    if (executionReceived && balanceReceived && subscriptionReady) {
-                        console.log('✅ Both execution and balance events received!');
-                        setTimeout(() => {
-                            stopWsApiConnections(true);
-                            done();
-                        }, 2000);
-                    }
+                    checkCompletion();
                 },
                 (execution) => {
                     // Execution callback
-                    console.log('📈 Execution report received:', execution);
+                    console.log('Execution report received:', execution);
                     executionReceived = true;
 
                     assert(execution !== null, WARN_SHOULD_BE_NOT_NULL);
@@ -579,14 +580,7 @@ describe('WebSocket API Live Tests', function () {
                     console.log(`  Execution Type: ${execution.x}`);
                     console.log(`  Order Status: ${execution.X}`);
 
-                    // Check if both events received
-                    if (executionReceived && balanceReceived && subscriptionReady) {
-                        console.log('✅ Both execution and balance events received!');
-                        setTimeout(() => {
-                            stopWsApiConnections(true);
-                            done();
-                        }, 2000);
-                    }
+                    checkCompletion();
                 },
                 async (endpoint) => {
                     // Subscribed callback
@@ -617,18 +611,16 @@ describe('WebSocket API Live Tests', function () {
                         // Set a backup timeout in case events are not received
                         setTimeout(() => {
                             if (!executionReceived || !balanceReceived) {
-                                console.error('⚠️ Timeout: Not all events received');
+                                console.error('Timeout: Not all events received');
                                 console.error(`  Execution received: ${executionReceived}`);
                                 console.error(`  Balance received: ${balanceReceived}`);
-                                stopWsApiConnections(true);
-                                done(new Error('Did not receive all expected events within timeout'));
+                                finish(new Error('Did not receive all expected events within timeout'));
                             }
                         }, 25000); // 25 second timeout
 
                     } catch (error: any) {
                         console.error('Error creating order:', error.message);
-                        stopWsApiConnections(true);
-                        done(error);
+                        finish(error);
                     }
                 },
                 (listStatus) => {