Skip to content

Commit 5007ca9

Browse files
Completely disable MacOS code signing (for now)
1 parent f5ccb38 commit 5007ca9

File tree

2 files changed

+43
-43
lines changed

2 files changed

+43
-43
lines changed

.github/workflows/make.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -39,34 +39,34 @@ jobs:
3939
if: ${{ matrix.os == 'ubuntu-latest' }}
4040
run: |
4141
sudo apt update && sudo apt install flatpak flatpak-builder elfutils
42-
- name: macOS certificate
43-
if: matrix.os == 'macos-13'
44-
env:
45-
APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
46-
APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
47-
run: |
48-
KEY_CHAIN=build.keychain
49-
CERTIFICATE_P12=certificate.p12
50-
echo $APPLE_CERTIFICATE | base64 --decode > $CERTIFICATE_P12
51-
security create-keychain -p actions $KEY_CHAIN
52-
security default-keychain -s $KEY_CHAIN
53-
security unlock-keychain -p actions $KEY_CHAIN
54-
security import $CERTIFICATE_P12 -k $KEY_CHAIN -P $APPLE_CERTIFICATE_PASSWORD -T /usr/bin/codesign;
55-
security set-key-partition-list -S apple-tool:,apple: -s -k actions $KEY_CHAIN
56-
rm -fr *.p12
42+
# - name: macOS certificate
43+
# if: matrix.os == 'macos-13'
44+
# env:
45+
# APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
46+
# APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
47+
# run: |
48+
# KEY_CHAIN=build.keychain
49+
# CERTIFICATE_P12=certificate.p12
50+
# echo $APPLE_CERTIFICATE | base64 --decode > $CERTIFICATE_P12
51+
# security create-keychain -p actions $KEY_CHAIN
52+
# security default-keychain -s $KEY_CHAIN
53+
# security unlock-keychain -p actions $KEY_CHAIN
54+
# security import $CERTIFICATE_P12 -k $KEY_CHAIN -P $APPLE_CERTIFICATE_PASSWORD -T /usr/bin/codesign;
55+
# security set-key-partition-list -S apple-tool:,apple: -s -k actions $KEY_CHAIN
56+
# rm -fr *.p12
5757
- name: Build release
58-
env:
59-
APPLE_ID: ${{ secrets.APPLE_ID }}
60-
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
61-
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
62-
APPLE_SIGNING_ID: ${{ secrets.APPLE_SIGNING_ID }}
58+
# env:
59+
# APPLE_ID: ${{ secrets.APPLE_ID }}
60+
# APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
61+
# APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
62+
# APPLE_SIGNING_ID: ${{ secrets.APPLE_SIGNING_ID }}
6363
shell: bash
6464
run: |
6565
npm ci
6666
if [[ "${{ matrix.os }}" != "macos-13" ]]; then
67-
npm run make
67+
npm run make -- --no-sign
6868
else
69-
npm run make -- --arch=universal
69+
npm run make -- --arch=universal --no-sign
7070
fi
7171
- uses: actions/upload-artifact@v3
7272
with:

.github/workflows/release.yml

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -45,32 +45,32 @@ jobs:
4545
if: matrix.os == 'macos-13'
4646
run: python3 -m pip install setuptools
4747
- run: npm ci
48-
- name: macOS certificate
49-
if: matrix.os == 'macos-13'
50-
env:
51-
APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
52-
APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
53-
run: |
54-
KEY_CHAIN=build.keychain
55-
CERTIFICATE_P12=certificate.p12
56-
echo $APPLE_CERTIFICATE | base64 --decode > $CERTIFICATE_P12
57-
security create-keychain -p actions $KEY_CHAIN
58-
security default-keychain -s $KEY_CHAIN
59-
security unlock-keychain -p actions $KEY_CHAIN
60-
security import $CERTIFICATE_P12 -k $KEY_CHAIN -P $APPLE_CERTIFICATE_PASSWORD -T /usr/bin/codesign;
61-
security set-key-partition-list -S apple-tool:,apple: -s -k actions $KEY_CHAIN
62-
rm -fr *.p12
48+
# - name: macOS certificate
49+
# if: matrix.os == 'macos-13'
50+
# env:
51+
# APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
52+
# APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
53+
# run: |
54+
# KEY_CHAIN=build.keychain
55+
# CERTIFICATE_P12=certificate.p12
56+
# echo $APPLE_CERTIFICATE | base64 --decode > $CERTIFICATE_P12
57+
# security create-keychain -p actions $KEY_CHAIN
58+
# security default-keychain -s $KEY_CHAIN
59+
# security unlock-keychain -p actions $KEY_CHAIN
60+
# security import $CERTIFICATE_P12 -k $KEY_CHAIN -P $APPLE_CERTIFICATE_PASSWORD -T /usr/bin/codesign;
61+
# security set-key-partition-list -S apple-tool:,apple: -s -k actions $KEY_CHAIN
62+
# rm -fr *.p12
6363
- name: publish
6464
env:
6565
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
66-
APPLE_ID: ${{ secrets.APPLE_ID }}
67-
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
68-
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
69-
APPLE_SIGNING_ID: ${{ secrets.APPLE_SIGNING_ID }}
66+
# APPLE_ID: ${{ secrets.APPLE_ID }}
67+
# APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
68+
# APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
69+
# APPLE_SIGNING_ID: ${{ secrets.APPLE_SIGNING_ID }}
7070
shell: bash
7171
run: |
7272
if [[ "${{ matrix.os }}" != "macos-13" ]]; then
73-
npm run publish
73+
npm run publish -- --no-sign
7474
else
75-
npm run publish -- --arch=universal
75+
npm run publish -- --arch=universal --no-sign
7676
fi

0 commit comments

Comments
 (0)