This repository was archived by the owner on Jul 24, 2025. It is now read-only.
Fix an undefined variable error in Validator::Type#89
Merged
tas50 merged 1 commit intochef-boneyard:masterfrom Jun 12, 2020
Merged
Fix an undefined variable error in Validator::Type#89tas50 merged 1 commit intochef-boneyard:masterfrom
tas50 merged 1 commit intochef-boneyard:masterfrom
Conversation
Signed-off-by: Yuta Harima <yuu725@gmail.com>
Contributor
Author
|
Local test is passing, but CI tests are failed. Those causes are older ruby version and lint existing code (this is not related my change). |
Contributor
|
Thanks @yuta1024. I'll cleanup the CI too |
Contributor
Author
|
@tas50 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validatemethod ofValidator::Typehas an undefined variable error.I didn't touch the test code. Because current tests are already passed before fixing and after fixing too.
I wrote the following verification code and ran. After fixing,
ChefAPI::Error::InvalidResourceis raised correctly.Before fixing:
After fixing:
Related Issue
None
Types of changes
Checklist: