Chore: validation on the number of max-keys in GetBucket

Signed-off-by: RichardLea <chigix@zoho.com>

Author: chigix

src/main/java/com/chigix/resserver/endpoint/GetBucket/ResourceListHandler.java

@@ -1,6 +1,7 @@
 package com.chigix.resserver.endpoint.GetBucket;
 
 import com.chigix.resserver.config.ApplicationContext;
+import com.chigix.resserver.domain.error.InvalidArgument;
 import com.chigix.resserver.domain.model.bucket.Bucket;
 import com.chigix.resserver.domain.model.resource.Resource;
 import com.chigix.resserver.domain.error.NoSuchBucket;
@@ -187,16 +188,35 @@ public int read() throws IOException {
         ctx.writeAndFlush(new HttpChunkedInput(new ChunkedStream(result))).addListener(ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE);
     }
 
-    private ListResponseContext buildListResponseContext(QueryStringDecoder query, Bucket bucket) {
+    private ListResponseContext buildListResponseContext(
+            QueryStringDecoder query, Bucket bucket)
+            throws InvalidArgument {
         ListResponseContext resp = new ListResponseContext(bucket);
         resp.delimiter = decodeQueryParamString(query, "delimiter");
         resp.startAfter = decodeQueryParamString(query, "start-after");
         resp.encodingType = decodeQueryParamString(query, "encoding-type");
         resp.prefix = decodeQueryParamString(query, "prefix");
-        String max_keys = decodeQueryParamString(query, "max-keys");
+        final String max_keys = decodeQueryParamString(query, "max-keys");
         if (max_keys != null) {
-            // @TODO Check exception for invalid format of integer number.
-            int max_keys_int = Integer.valueOf(max_keys);
+            final int max_keys_int;
+            try {
+                max_keys_int = Integer.valueOf(max_keys);
+            } catch (NumberFormatException numberFormatException) {
+                throw new InvalidMaxKeys() {
+                    @Override
+                    public String getArgumentValue() {
+                        return max_keys;
+                    }
+                };
+            }
+            if (max_keys_int < 0 || max_keys_int > 2147483647) {
+                throw new InvalidMaxKeys() {
+                    @Override
+                    public String getArgumentValue() {
+                        return max_keys_int + "";
+                    }
+                };
+            }
             resp.maxKeys = max_keys_int;
         }
         resp.continuationToken = decodeQueryParamString(query, "continuation-token");
@@ -369,4 +389,21 @@ public ListResponseContext(Bucket bucket) {
 
     }
 
+    private static abstract class InvalidMaxKeys extends InvalidArgument implements
+            InvalidArgument.ArgumentNameInclude,
+            InvalidArgument.ArgumentValueInclude {
+
+        @Override
+        public String getMessage() {
+            return "Argument maxKeys must be an integer "
+                    + "between 0 and 2147483647";
+        }
+
+        @Override
+        public String getArgumentName() {
+            return "maxKeys";
+        }
+
+    }
+
 }

src/test/resources/aws_response/get-bucket-wrong-maxkey

@@ -0,0 +1,28 @@
+> GET /?delimiter=%2F&fetch-owner=true&list-type=2&max-keys=-1 HTTP/1.1
+> Host: oos-for-learning.s3-ap-northeast-1.amazonaws.com
+> Authorization: AWS4-HMAC-SHA256 ####
+> X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
+> X-Amz-Date: 20180102T151435Z
+> User-Agent: Minio (windows; amd64) minio-go/2.0.2 mc/2016-12-09T18:23:19Z
+> Expect: 100-continue
+> Accept: */*
+
+< HTTP/1.1 400 Bad Request
+< x-amz-bucket-region: ap-northeast-1
+< x-amz-request-id: FAB3F6AAFB6870C9
+< x-amz-id-2: 8W2ZWqDON7sX8h33WKQLIqjFJ7uLCScp88dopBNCwLYDwzRzi47qhaQvw8uqmZg7ZYpqx/XJnr0=
+< Content-Type: application/xml
+< Transfer-Encoding: chunked
+< Date: Tue, 02 Jan 2018 15:14:49 GMT
+< Connection: close
+< Server: AmazonS3
+
+<?xml version="1.0" encoding="UTF-8"?>
+<Error>
+	<Code>InvalidArgument</Code>
+	<Message>Argument maxKeys must be an integer between 0 and 2147483647</Message>
+	<ArgumentName>maxKeys</ArgumentName>
+	<ArgumentValue>-1</ArgumentValue>
+	<RequestId>FAB3F6AAFB6870C9</RequestId>
+	<HostId>8W2ZWqDON7sX8h33WKQLIqjFJ7uLCScp88dopBNCwLYDwzRzi47qhaQvw8uqmZg7ZYpqx/XJnr0=</HostId>
+</Error>