Update to version 1.1

Author: chrisnolet

QuickOutline/Readme.txt

@@ -7,8 +7,9 @@ Developed by Chris Nolet (c) 2018
 Instructions
 ------------
 
-To add an outline to an object, drag-and-drop the Outline.cs script onto the
-object. The outline materials will be loaded at runtime.
+To add an outline to an object, drag-and-drop the Outline.cs
+script onto the object. The outline materials will be loaded
+at runtime.
 
 You can also add outlines programmatically with:
 
@@ -18,9 +19,19 @@ You can also add outlines programmatically with:
     outline.OutlineColor = Color.yellow;
     outline.OutlineWidth = 5f;
 
-The outline script does a small amount of work in Awake(). For best results,
-use outline.enabled to toggle the outline. Avoid removing and re-adding the
-component if possible.
+The outline script does a small amount of work in Awake().
+For best results, use outline.enabled to toggle the outline.
+Avoid removing and re-adding the component if possible.
 
-For large meshes, you may also like to enable 'Precompute Outline' in the
-editor. This will reduce the amount of work performed in Awake().
+For large meshes, you may also like to enable 'Precompute
+Outline' in the editor. This will reduce the amount of work
+performed in Awake().
+
+
+Troubleshooting
+---------------
+
+If the outline appears off-center, please try the following:
+
+1. Set 'Read/Write Enabled' on each model's import settings.
+2. Disable 'Optimize Mesh Data' in the player settings.

QuickOutline/Scripts/Outline.cs

@@ -193,13 +193,28 @@ void LoadSmoothNormals() {
 
       // Store smooth normals in UV3
       meshFilter.sharedMesh.SetUVs(3, smoothNormals);
+
+      // Combine submeshes
+      var renderer = meshFilter.GetComponent<Renderer>();
+
+      if (renderer != null) {
+        CombineSubmeshes(meshFilter.sharedMesh, renderer.sharedMaterials);
+      }
     }
 
     // Clear UV3 on skinned mesh renderers
     foreach (var skinnedMeshRenderer in GetComponentsInChildren<SkinnedMeshRenderer>()) {
-      if (registeredMeshes.Add(skinnedMeshRenderer.sharedMesh)) {
-        skinnedMeshRenderer.sharedMesh.uv4 = new Vector2[skinnedMeshRenderer.sharedMesh.vertexCount];
+
+      // Skip if UV3 has already been reset
+      if (!registeredMeshes.Add(skinnedMeshRenderer.sharedMesh)) {
+        continue;
       }
+
+      // Clear UV3
+      skinnedMeshRenderer.sharedMesh.uv4 = new Vector2[skinnedMeshRenderer.sharedMesh.vertexCount];
+
+      // Combine submeshes
+      CombineSubmeshes(skinnedMeshRenderer.sharedMesh, skinnedMeshRenderer.sharedMaterials);
     }
   }
 
@@ -223,7 +238,7 @@ List<Vector3> SmoothNormals(Mesh mesh) {
       var smoothNormal = Vector3.zero;
 
       foreach (var pair in group) {
-        smoothNormal += mesh.normals[pair.Value];
+        smoothNormal += smoothNormals[pair.Value];
       }
 
       smoothNormal.Normalize();
@@ -237,6 +252,23 @@ List<Vector3> SmoothNormals(Mesh mesh) {
     return smoothNormals;
   }
 
+  void CombineSubmeshes(Mesh mesh, Material[] materials) {
+
+    // Skip meshes with a single submesh
+    if (mesh.subMeshCount == 1) {
+      return;
+    }
+
+    // Skip if submesh count exceeds material count
+    if (mesh.subMeshCount > materials.Length) {
+      return;
+    }
+
+    // Append combined submesh
+    mesh.subMeshCount++;
+    mesh.SetTriangles(mesh.triangles, mesh.subMeshCount - 1);
+  }
+
   void UpdateMaterialProperties() {
 
     // Apply properties according to mode

Readme.md

@@ -38,3 +38,12 @@ You can also add outlines programmatically with:
 The outline script does a small amount of work in Awake(). For best results, use outline.enabled to toggle the outline. Avoid removing and re-adding the component if possible.
 
 For large meshes, you may also like to enable 'Precompute Outline' in the editor. This will reduce the amount of work performed in Awake().
+
+
+Troubleshooting
+---------------
+
+If the outline appears off-center, please try the following:
+
+1. Set 'Read/Write Enabled' on each model's import settings.
+2. Disable 'Optimize Mesh Data' in the player settings.