git-er-done

Author: westonganger

.rubocop.yml

@@ -45,6 +45,12 @@ Layout/MultilineOperationIndentation:
 Layout/SpaceBeforeComment:
   Enabled: false
 
+Layout/SpaceBeforeBlockBraces:
+  Enabled: false
+
+Layout/SpaceAroundBlockParameters:
+  Enabled: false
+
 LeadingCommentSpace:
   Enabled: false
 
@@ -158,6 +164,9 @@ Style/LineEndConcatenation:
 Style/RedundantReturn:
   Enabled: false
 
+Style/Proc:
+  Enabled: false
+
 # The Ruby Style Guide does not prescribe a particular quote character, only
 # that a project should pick one and be consistent. The decision has no
 # performance implications. Double quotes are slightly easier to read.

Rakefile

@@ -45,11 +45,17 @@ task :autocorrect do
     'Style/EmptyMethod',
     'Style/TrailingCommaInArguments',
   ]
-  `bundle exec rubocop --auto-correct --only  #{rules.join(' --only ')}`
+
+  rules.each do |rule|
+    `bundle exec rubocop --auto-correct --only #{rule}`
+  end
+
+  Rake::Task['rubocop'].invoke
 end
 
 require "rubocop/rake_task"
 RuboCop::RakeTask.new
 
+### TODO: Allow rubocop to fail, but still continue
 desc "Default: run all available test suites"
-task default: %i[autocorrect rubocop prepare test spec]
+task default: %i[rubocop prepare test spec]

lib/paper_trail_association_tracking.rb

@@ -16,9 +16,9 @@ def self.gem_version
 end
 
 module PaperTrail
-  #class << self
-  #  prepend ::PaperTrailAssociationTracking::PaperTrail
-  #end
+  class << self
+    prepend ::PaperTrailAssociationTracking::PaperTrail
+  end
 
   class Config
     prepend ::PaperTrailAssociationTracking::Config

lib/paper_trail_association_tracking/paper_trail.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module PaperTrailAssociationTracking
+  module PaperTrail
+    def transaction?
+      ::ActiveRecord::Base.connection.open_transactions.positive?
+    end
+  end
+end

lib/paper_trail_association_tracking/record_trail.rb

@@ -1,8 +1,130 @@
 # frozen_string_literal: true
 
 module PaperTrailAssociationTracking
-  # Represents the "paper trail" for a single record.
   class RecordTrail
+    # Utility method for reifying. Anything executed inside the block will
+    # appear like a new record.
+    #
+    # > .. as best as I can tell, the purpose of
+    # > appear_as_new_record was to attempt to prevent the callbacks in
+    # > AutosaveAssociation (which is the module responsible for persisting
+    # > foreign key changes earlier than most people want most of the time
+    # > because backwards compatibility or the maintainer hates himself or
+    # > something) from running. By also stubbing out persisted? we can
+    # > actually prevent those. A more stable option might be to use suppress
+    # > instead, similar to the other branch in reify_has_one.
+    # > -Sean Griffin (https://github.com/paper-trail-gem/paper_trail/pull/899)
+    #
+    # @api private
+    # def appear_as_new_record
+    #   @record.instance_eval {
+    #     alias :old_new_record? :new_record?
+    #     alias :new_record? :present?
+    #     alias :old_persisted? :persisted?
+    #     alias :persisted? :nil?
+    #   }
+    #   yield
+    #   @record.instance_eval {
+    #     alias :new_record? :old_new_record?
+    #     alias :persisted? :old_persisted?
+    #   }
+    # end
+
+    def record_create
+      @in_after_callback = true
+      return unless enabled?
+      versions_assoc = @record.send(@record.class.versions_association_name)
+      version = versions_assoc.create! data_for_create
+      update_transaction_id(version)
+      save_associations(version)
+    ensure
+      @in_after_callback = false
+    end
+
+    def data_for_create
+      data = super
+      add_transaction_id_to(data)
+      data
+    end
+
+    def record_destroy(recording_order)
+      @in_after_callback = recording_order == "after"
+      if enabled? && !@record.new_record?
+        version = @record.class.paper_trail.version_class.create(data_for_destroy)
+        if version.errors.any?
+          log_version_errors(version, :destroy)
+        else
+          @record.send("#{@record.class.version_association_name}=", version)
+          @record.send(@record.class.versions_association_name).reset
+          update_transaction_id(version)
+          save_associations(version)
+        end
+      end
+    ensure
+      @in_after_callback = false
+    end
+
+    def data_for_destroy
+      data = super
+      add_transaction_id_to(data)
+      data
+    end
+
+    # Returns a boolean indicating whether to store serialized version diffs
+    # in the `object_changes` column of the version record.
+    # @api private
+    def record_object_changes?
+      @record.paper_trail_options[:save_changes] &&
+        @record.class.paper_trail.version_class.column_names.include?("object_changes")
+    end
+
+    def record_update(force:, in_after_callback:, is_touch:)
+      @in_after_callback = in_after_callback
+      if enabled? && (force || changed_notably?)
+        versions_assoc = @record.send(@record.class.versions_association_name)
+        version = versions_assoc.create(data_for_update(is_touch))
+        if version.errors.any?
+          log_version_errors(version, :update)
+        else
+          update_transaction_id(version)
+          save_associations(version)
+        end
+      end
+    ensure
+      @in_after_callback = false
+    end
+
+    # Used during `record_update`, returns a hash of data suitable for an AR
+    # `create`. That is, all the attributes of the nascent `Version` record.
+    #
+    # @api private
+    def data_for_update(is_touch)
+      data = super
+      add_transaction_id_to(data)
+      data
+    end
+
+    # @api private
+    def record_update_columns(changes)
+      return unless enabled?
+      versions_assoc = @record.send(@record.class.versions_association_name)
+      version = versions_assoc.create(data_for_update_columns(changes))
+      if version.errors.any?
+        log_version_errors(version, :update)
+      else
+        update_transaction_id(version)
+        save_associations(version)
+      end
+    end
+
+    # Returns data for record_update_columns
+    # @api private
+    def data_for_update_columns(changes)
+      data = super
+      add_transaction_id_to(data)
+      data
+    end
+
     # Saves associations if the join table for `VersionAssociation` exists.
     def save_associations(version)
       return unless PaperTrail.config.track_associations?

lib/paper_trail_association_tracking/request.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module PaperTrailAssociationTracking
+  module Request
+    # @api private
+    def self.clear_transaction_id
+      self.transaction_id = nil
+    end
+
+    # @api private
+    def self.transaction_id
+      store[:transaction_id]
+    end
+
+    # @api private
+    def self.transaction_id=(id)
+      store[:transaction_id] = id
+    end
+  end
+end