No more intermediate decompression and metaflac passes

flac supports reading in a FLAC file directly for source input, and
writes out a new file with the desired compression file based on it.
Use this to speed up operation and make it a little more reliable,
copying all metadata and ancillary streams (such as artwork) without
worry about leaving them out.

Additionally, the `--verify` flag is now used too, giving extra
assurance that the output FLAC file is correct.  I have strong doubts
this is actually necessary; I think decoding errors will be caught and
should cover enough, but this has been requested twice now and the
performance impact is offset by the overall improvement in this
commit.

Thanks @Entze and @wlhlm for the suggestions

Closes: #5, #6

Author: chungy

reflac

@@ -65,32 +65,18 @@ recompress()
         fi
 
         if [ $NOACTION -eq 0 ]; then
-            HAS_COVER_ART=1
-            metaflac --no-utf8-convert \
-                     --export-tags-to="$TMPDIR/$(basename -s flac -- "$flac")tag" \
-                     -- "$flac"
-            metaflac --export-picture-to="$TMPDIR/$(basename -s flac -- "$flac")img" \
-                     -- "$flac" > /dev/null 2>&1 || HAS_COVER_ART=0 #the error is handled later. do not exit the script
             if [ $VERBOSE -gt 1 ]; then
-                flac --force-rf64-format --output-prefix="$TMPDIR/" -d -- "$flac"
-                flac --delete-input-file -$FLAC_LEVEL -- \
-                     "$TMPDIR/$(basename -s flac -- "$flac")rf64"
+                flac -$FLAC_LEVEL \
+                     --output-name="${TMPDIR}/$(basename -- "$flac")" \
+                     --verify -- \
+                     "$flac"
             else
-                flac -s --force-rf64-format --output-prefix="$TMPDIR/" -d -- "$flac"
-                flac -s --delete-input-file -$FLAC_LEVEL -- \
-                     "$TMPDIR/$(basename -s flac -- "$flac")rf64"
+                flac --silent -$FLAC_LEVEL \
+                     --output-name="${TMPDIR}/$(basename -- "$flac")" \
+                     --verify -- \
+                     "$flac"
             fi
 
-            if [ $HAS_COVER_ART -eq 1 ]; then
-                metaflac --no-utf8-convert $PRESERVE_MODTIME \
-                        --import-tags-from="$TMPDIR/$(basename -s flac -- "$flac")tag" \
-                        --import-picture-from="$TMPDIR/$(basename -s flac -- "$flac")img" \
-                        -- "$TMPDIR/$flac"
-            else
-                metaflac --no-utf8-convert $PRESERVE_MODTIME \
-                        --import-tags-from="$TMPDIR/$(basename -s flac -- "$flac")tag" \
-                        -- "$TMPDIR/$flac"
-            fi
             mv -f -- "$TMPDIR/$flac" "$flac.new"
             if [ $SYNC -eq 1 ]; then
                 sync "$flac.new"
@@ -99,8 +85,6 @@ recompress()
             else
                 mv -f "$flac.new" "$flac"
             fi
-            rm -f -- "$TMPDIR/$(basename -s flac -- "$flac")tag" \
-                     "$TMPDIR/$(basename -s flac -- "$flac")img"
         fi
     done
 }