From 291a37ec044f334acfd5e6db5489d61e9ab0c7e1 Mon Sep 17 00:00:00 2001 From: Tom Milewski Date: Sat, 14 Oct 2023 12:20:00 -0400 Subject: [PATCH 1/3] build(repo): Narrow Turborepo inputs for tasks --- ...est.afterEnv.ts => jest.setup-after-env.ts | 0 package.json | 8 ++-- packages/backend/turbo.json | 18 ++++++++ packages/chrome-extension/jest.config.js | 2 +- packages/chrome-extension/turbo.json | 29 +++++++++++++ packages/clerk-js/jest.config.js | 4 +- ...estAfterEnv.ts => jest.setup-after-env.ts} | 0 .../clerk-js/{setupJest.ts => jest.setup.ts} | 0 packages/clerk-js/tsconfig.test.json | 2 +- packages/clerk-js/turbo.json | 35 +++++++++++++++ packages/fastify/turbo.json | 20 +++++++++ packages/nextjs/turbo.json | 24 +++++++++++ packages/react/jest.config.js | 2 +- packages/react/turbo.json | 31 +++++++++++++ packages/remix/turbo.json | 31 +++++++++++++ packages/sdk-node/jest.config.js | 2 +- .../{setupEnvVars.js => jest.setup.js} | 0 packages/sdk-node/turbo.json | 32 ++++++++++++++ packages/shared/jest.config.js | 2 +- .../shared/{setupJest.ts => jest.setup.ts} | 0 packages/shared/turbo.json | 33 ++++++++++++++ packages/themes/turbo.json | 8 ++++ packages/types/turbo.json | 8 ++++ tsconfig.eslint.json | 16 +++---- turbo.json | 43 ++++++++----------- 25 files changed, 307 insertions(+), 43 deletions(-) rename setupJest.afterEnv.ts => jest.setup-after-env.ts (100%) create mode 100644 packages/backend/turbo.json create mode 100644 packages/chrome-extension/turbo.json rename packages/clerk-js/{setupJestAfterEnv.ts => jest.setup-after-env.ts} (100%) rename packages/clerk-js/{setupJest.ts => jest.setup.ts} (100%) create mode 100644 packages/clerk-js/turbo.json create mode 100644 packages/fastify/turbo.json create mode 100644 packages/nextjs/turbo.json create mode 100644 packages/react/turbo.json create mode 100644 packages/remix/turbo.json rename packages/sdk-node/{setupEnvVars.js => jest.setup.js} (100%) create mode 100644 packages/sdk-node/turbo.json rename packages/shared/{setupJest.ts => jest.setup.ts} (100%) create mode 100644 packages/shared/turbo.json create mode 100644 packages/themes/turbo.json create mode 100644 packages/types/turbo.json diff --git a/setupJest.afterEnv.ts b/jest.setup-after-env.ts similarity index 100% rename from setupJest.afterEnv.ts rename to jest.setup-after-env.ts diff --git a/package.json b/package.json index 3d2500ad033..02d15601d0e 100644 --- a/package.json +++ b/package.json @@ -88,10 +88,10 @@ "version": "npx changeset version && ./scripts/version-info.sh", "version:snapshot": "./scripts/snapshot.mjs", "version:staging": "./scripts/staging.mjs", - "release": "FORCE_COLOR=1 npm run build -- --force && npx changeset publish && git push --follow-tags", - "release:snapshot": "FORCE_COLOR=1 npm run build && npx changeset publish --tag snapshot --no-git-tag", - "release:staging": "FORCE_COLOR=1 npm run build && npx changeset publish --tag staging --no-git-tag", - "release:verdaccio": "if [ \"$(npm config get registry)\" = \"https://registry.npmjs.org/\" ]; then echo 'Error: Using default registry' && exit 1; else TURBO_CONCURRENCY=4 npm run build && npx changeset publish --no-git-tag; fi", + "release": "TURBO_FORCE=true FORCE_COLOR=1 npm run build -- --force && npx changeset publish && git push --follow-tags", + "release:snapshot": "TURBO_FORCE=true ORCE_COLOR=1 npm run build && npx changeset publish --tag snapshot --no-git-tag", + "release:staging": "TURBO_FORCE=true FORCE_COLOR=1 npm run build && npx changeset publish --tag staging --no-git-tag", + "release:verdaccio": "if [ \"$(npm config get registry)\" = \"https://registry.npmjs.org/\" ]; then echo 'Error: Using default registry' && exit 1; else TURBO_FORCE=true TURBO_CONCURRENCY=4 npm run build && npx changeset publish --no-git-tag; fi", "update:lockfile": "npm run nuke && npm install -D --arch=x64 --platform=linux turbo && npm install -D --arch=arm64 --platform=darwin turbo" } } diff --git a/packages/backend/turbo.json b/packages/backend/turbo.json new file mode 100644 index 00000000000..bf9728f4023 --- /dev/null +++ b/packages/backend/turbo.json @@ -0,0 +1,18 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": ["src/**", "tsup.config.ts", "tsconfig.json", "tsconfig.declarations.json"] + }, + "test": { + "inputs": [ + "src/**", + "tests/**", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + "tsconfig.test.json" + ] + } + } +} diff --git a/packages/chrome-extension/jest.config.js b/packages/chrome-extension/jest.config.js index 882e10b0fe4..6bab963d68c 100644 --- a/packages/chrome-extension/jest.config.js +++ b/packages/chrome-extension/jest.config.js @@ -7,7 +7,7 @@ module.exports = { roots: ['/src'], testEnvironment: 'jsdom', - setupFilesAfterEnv: ['../../setupJest.afterEnv.ts'], + setupFilesAfterEnv: ['../../jest.setup-after-env.ts'], moduleDirectories: ['node_modules', '/src'], transform: { diff --git a/packages/chrome-extension/turbo.json b/packages/chrome-extension/turbo.json new file mode 100644 index 00000000000..806cc94fe25 --- /dev/null +++ b/packages/chrome-extension/turbo.json @@ -0,0 +1,29 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + + "!coverage/**", + "!src/**/*.test.*", + "!src/**/__snapshots__/**" + ] + }, + "test": { + "inputs": [ + "src/**", + "jest.*", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + + "!coverage/**", + "!src/**/__snapshots__/**" + ] + } + } +} diff --git a/packages/clerk-js/jest.config.js b/packages/clerk-js/jest.config.js index 21b5eeb4c15..b845500891c 100644 --- a/packages/clerk-js/jest.config.js +++ b/packages/clerk-js/jest.config.js @@ -5,8 +5,8 @@ const config = { testEnvironment: '/jsdom-with-timezone.ts', roots: ['/src'], - setupFiles: ['./setupJest.ts'], - setupFilesAfterEnv: ['./setupJestAfterEnv.ts'], + setupFiles: ['./jest.setup.ts'], + setupFilesAfterEnv: ['./jest.setup-after-env.ts'], testRegex: [ '/__tests__/(.+/)*.*.test.[jt]sx?$', '/ui/.*/__tests__/.*.test.[jt]sx?$', diff --git a/packages/clerk-js/setupJestAfterEnv.ts b/packages/clerk-js/jest.setup-after-env.ts similarity index 100% rename from packages/clerk-js/setupJestAfterEnv.ts rename to packages/clerk-js/jest.setup-after-env.ts diff --git a/packages/clerk-js/setupJest.ts b/packages/clerk-js/jest.setup.ts similarity index 100% rename from packages/clerk-js/setupJest.ts rename to packages/clerk-js/jest.setup.ts diff --git a/packages/clerk-js/tsconfig.test.json b/packages/clerk-js/tsconfig.test.json index 97f9024bed3..72bee288c2a 100644 --- a/packages/clerk-js/tsconfig.test.json +++ b/packages/clerk-js/tsconfig.test.json @@ -1,5 +1,5 @@ { "extends": "./tsconfig.json", - "include": ["src/**/*", "./setupJestAfterEnv.ts"], + "include": ["src/**/*", "./jest.setup-after-env.ts"], "exclude": ["node_modules"] } diff --git a/packages/clerk-js/turbo.json b/packages/clerk-js/turbo.json new file mode 100644 index 00000000000..777ad057889 --- /dev/null +++ b/packages/clerk-js/turbo.json @@ -0,0 +1,35 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "headless/**", + "bundlewatch.config.json", + "tsconfig.json", + "tsconfig.declarations.json", + "webpack.config.js", + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**" + ] + }, + "test": { + "inputs": [ + "src/**", + "headless/**", + "jest.*", + "svgTransform.js", + "webpack.config.js", + "tsconfig.json", + "tsconfig.test.json", + "!**/__snapshots__/**", + "!coverage/**" + ] + } + } +} diff --git a/packages/fastify/turbo.json b/packages/fastify/turbo.json new file mode 100644 index 00000000000..aee16686bd9 --- /dev/null +++ b/packages/fastify/turbo.json @@ -0,0 +1,20 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "tsup.config.ts", + "tsconfig.json", + "!**/**/*.test.*", + "!**/test/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**" + ] + }, + "test": { + "inputs": ["src/**", "jest.*", "tsup.config.ts", "tsconfig.json", "!**/__snapshots__/**", "!coverage/**"] + } + } +} diff --git a/packages/nextjs/turbo.json b/packages/nextjs/turbo.json new file mode 100644 index 00000000000..83d85a35ecd --- /dev/null +++ b/packages/nextjs/turbo.json @@ -0,0 +1,24 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "**/package.json", + "src/**", + "!examples/**", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**" + ] + }, + "test": { + "inputs": ["src/**", "jest.*", "tsup.config.ts", "tsconfig.*", "!**/__snapshots__/**", "!coverage/**"] + } + } +} diff --git a/packages/react/jest.config.js b/packages/react/jest.config.js index 44b634b7142..e37103a5711 100644 --- a/packages/react/jest.config.js +++ b/packages/react/jest.config.js @@ -4,7 +4,7 @@ module.exports = { roots: ['/src'], testEnvironment: 'jsdom', - setupFilesAfterEnv: ['../../setupJest.afterEnv.ts'], + setupFilesAfterEnv: ['../../jest.setup-after-env.ts'], moduleDirectories: ['node_modules', '/src'], transform: { diff --git a/packages/react/turbo.json b/packages/react/turbo.json new file mode 100644 index 00000000000..d2e77c63896 --- /dev/null +++ b/packages/react/turbo.json @@ -0,0 +1,31 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**" + ] + }, + "test": { + "inputs": [ + "src/**", + "jest.*", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.*.json", + "!**/__snapshots__/**", + "!coverage/**" + ] + } + } +} diff --git a/packages/remix/turbo.json b/packages/remix/turbo.json new file mode 100644 index 00000000000..d2e77c63896 --- /dev/null +++ b/packages/remix/turbo.json @@ -0,0 +1,31 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**" + ] + }, + "test": { + "inputs": [ + "src/**", + "jest.*", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.*.json", + "!**/__snapshots__/**", + "!coverage/**" + ] + } + } +} diff --git a/packages/sdk-node/jest.config.js b/packages/sdk-node/jest.config.js index 13a98183d6f..bf00d606ee1 100644 --- a/packages/sdk-node/jest.config.js +++ b/packages/sdk-node/jest.config.js @@ -4,7 +4,7 @@ module.exports = { transform: { '^.+\\.ts$': 'ts-jest', }, - setupFiles: ['/setupEnvVars.js'], + setupFiles: ['/jest.setup.js'], collectCoverage: true, // Jest currently does not support package.json subpath imports // so we manually map them to the actual files. See @clerk/backend/package.json diff --git a/packages/sdk-node/setupEnvVars.js b/packages/sdk-node/jest.setup.js similarity index 100% rename from packages/sdk-node/setupEnvVars.js rename to packages/sdk-node/jest.setup.js diff --git a/packages/sdk-node/turbo.json b/packages/sdk-node/turbo.json new file mode 100644 index 00000000000..aae5e901453 --- /dev/null +++ b/packages/sdk-node/turbo.json @@ -0,0 +1,32 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "scripts/**", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**" + ] + }, + "test": { + "inputs": [ + "src/**", + "jest.*", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.*.json", + "!**/__snapshots__/**", + "!coverage/**" + ] + } + } +} diff --git a/packages/shared/jest.config.js b/packages/shared/jest.config.js index d2615837d8f..a2b723665c1 100644 --- a/packages/shared/jest.config.js +++ b/packages/shared/jest.config.js @@ -5,7 +5,7 @@ const config = { testEnvironment: 'jsdom', roots: ['/src'], - setupFiles: ['./setupJest.ts'], + setupFiles: ['./jest.setup.ts'], collectCoverage: false, coverageProvider: 'v8', diff --git a/packages/shared/setupJest.ts b/packages/shared/jest.setup.ts similarity index 100% rename from packages/shared/setupJest.ts rename to packages/shared/jest.setup.ts diff --git a/packages/shared/turbo.json b/packages/shared/turbo.json new file mode 100644 index 00000000000..a426177a8ca --- /dev/null +++ b/packages/shared/turbo.json @@ -0,0 +1,33 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": [ + "src/**", + "global.d.ts", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.declarations.json", + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**" + ] + }, + "test": { + "inputs": [ + "src/**", + "jest.*", + "global.d.ts", + "tsup.config.ts", + "tsconfig.json", + "tsconfig.*.json", + "!**/__snapshots__/**", + "!coverage/**" + ] + } + } +} diff --git a/packages/themes/turbo.json b/packages/themes/turbo.json new file mode 100644 index 00000000000..04b16095e1c --- /dev/null +++ b/packages/themes/turbo.json @@ -0,0 +1,8 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": ["src/**", "tsconfig.json", "tsconfig.buid.json"] + } + } +} diff --git a/packages/types/turbo.json b/packages/types/turbo.json new file mode 100644 index 00000000000..e8b84233f83 --- /dev/null +++ b/packages/types/turbo.json @@ -0,0 +1,8 @@ +{ + "extends": ["//"], + "pipeline": { + "build": { + "inputs": ["src/**", "tsconfig.*"] + } + } +} diff --git a/tsconfig.eslint.json b/tsconfig.eslint.json index d67b88526ca..cf89b1187b0 100644 --- a/tsconfig.eslint.json +++ b/tsconfig.eslint.json @@ -5,16 +5,16 @@ "allowJs": true }, "include": [ + ".eslintrc.js", + "commitlint.config.js", + "jest.*.ts", + "integration/*/*.js", + "integration/**/*.ts", + "integration/**/*.tsx", "packages/*/src", + "packages/*/*.js", "packages/**/*.ts", "packages/**/*.tsx", - "packages/*/*.js", - "integration/**/*.ts", - "integration/**/*.tsx", - "integration/*/*.js", - ".eslintrc.js", - "commitlint.config.js", - "scripts/*.mjs", - "setupJest.afterEnv.ts" + "scripts/*.mjs" ] } diff --git a/turbo.json b/turbo.json index 8528e466182..025ebad9bdb 100644 --- a/turbo.json +++ b/turbo.json @@ -3,42 +3,34 @@ "remoteCache": { "signature": true }, - "globalDependencies": [ + ".*", + "jest.*.ts", "packages/eslint-config-custom/index.js", "package.json", "package-lock.json", - "setupJest.afterEnv.ts", "tsconfig.json", - "tsconfig.*.json" + "tsconfig.*.json", + "verdaccio.*.yaml" ], "globalEnv": [ + "CI", + "CLERK_*", + "GATSBY_CLERK_*", + "NEXT_PUBLIC_CLERK_*", + "NODE_ENV", + "NODE_EXTRA_CA_CERTS", "NODE_VERSION", "NPM_VERSION", - "NODE_ENV", - "VERCEL", - "CLERK_JS_VERSION", - "CLERK_API_URL", - "CLERK_API_VERSION", - "CLERK_API_KEY", - "CLERK_SECRET_KEY", - "GATSBY_CLERK_JS", - "GATSBY_CLERK_FRONTEND_API", - "GATSBY_CLERK_PROXY_URL", - "GATSBY_CLERK_PUBLISHABLE_KEY", - "NEXT_PUBLIC_CLERK_JS_VERSION", - "NEXT_PUBLIC_CLERK_JS", - "NEXT_PUBLIC_CLERK_FRONTEND_API", - "NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY", - "NEXT_PUBLIC_CLERK_DOMAIN", - "NEXT_PUBLIC_CLERK_PROXY_URL", - "NEXT_PUBLIC_CLERK_IS_SATELLITE", - "NEXT_PUBLIC_CLERK_SIGN_IN_URL", - "NEXT_PUBLIC_CLERK_SIGN_UP_URL" + "RUNNER_ARCH", + "RUNNER_DEBUG", + "RUNNER_OS", + "VERCEL" ], "pipeline": { "build": { "dependsOn": ["^build"], + "outputMode": "new-only", "outputs": ["dist/**"] }, "dev": { @@ -46,8 +38,8 @@ "cache": false }, "dev:current": { - "dependsOn": ["^build", "dev"], "cache": false, + "dependsOn": ["^build", "dev"], "persistent": true }, "clean": { @@ -56,14 +48,17 @@ }, "test": { "dependsOn": ["build"], + "outputMode": "new-only", "outputs": [] }, "test:ci": { "dependsOn": ["build"], + "outputMode": "new-only", "outputs": [] }, "lint": { "dependsOn": [], + "inputs": ["src/**"], "outputs": [] }, "lint:publint": { From c64e8e612a85703938f049b87a4c243c5cc86c29 Mon Sep 17 00:00:00 2001 From: Tom Milewski Date: Sat, 14 Oct 2023 13:41:05 -0400 Subject: [PATCH 2/3] build(repo): Consolidate common inputs --- .changeset/dull-ducks-dance.md | 2 + packages/backend/turbo.json | 18 ------- packages/chrome-extension/turbo.json | 29 ---------- packages/clerk-js/jest.config.js | 2 +- ...imezone.ts => jest.jsdom-with-timezone.ts} | 0 packages/clerk-js/turbo.json | 48 ++++++++++++++--- packages/fastify/turbo.json | 20 ------- packages/nextjs/turbo.json | 24 --------- packages/react/turbo.json | 31 ----------- packages/remix/turbo.json | 31 ----------- packages/sdk-node/turbo.json | 22 ++++---- packages/shared/turbo.json | 33 ------------ packages/themes/turbo.json | 8 --- packages/types/turbo.json | 8 --- turbo.json | 53 +++++++++++++++++++ 15 files changed, 106 insertions(+), 223 deletions(-) create mode 100644 .changeset/dull-ducks-dance.md delete mode 100644 packages/backend/turbo.json delete mode 100644 packages/chrome-extension/turbo.json rename packages/clerk-js/{jsdom-with-timezone.ts => jest.jsdom-with-timezone.ts} (100%) delete mode 100644 packages/fastify/turbo.json delete mode 100644 packages/nextjs/turbo.json delete mode 100644 packages/react/turbo.json delete mode 100644 packages/remix/turbo.json delete mode 100644 packages/shared/turbo.json delete mode 100644 packages/themes/turbo.json delete mode 100644 packages/types/turbo.json diff --git a/.changeset/dull-ducks-dance.md b/.changeset/dull-ducks-dance.md new file mode 100644 index 00000000000..a845151cc84 --- /dev/null +++ b/.changeset/dull-ducks-dance.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/packages/backend/turbo.json b/packages/backend/turbo.json deleted file mode 100644 index bf9728f4023..00000000000 --- a/packages/backend/turbo.json +++ /dev/null @@ -1,18 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": ["src/**", "tsup.config.ts", "tsconfig.json", "tsconfig.declarations.json"] - }, - "test": { - "inputs": [ - "src/**", - "tests/**", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - "tsconfig.test.json" - ] - } - } -} diff --git a/packages/chrome-extension/turbo.json b/packages/chrome-extension/turbo.json deleted file mode 100644 index 806cc94fe25..00000000000 --- a/packages/chrome-extension/turbo.json +++ /dev/null @@ -1,29 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": [ - "src/**", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - - "!coverage/**", - "!src/**/*.test.*", - "!src/**/__snapshots__/**" - ] - }, - "test": { - "inputs": [ - "src/**", - "jest.*", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - - "!coverage/**", - "!src/**/__snapshots__/**" - ] - } - } -} diff --git a/packages/clerk-js/jest.config.js b/packages/clerk-js/jest.config.js index b845500891c..3464b1d1036 100644 --- a/packages/clerk-js/jest.config.js +++ b/packages/clerk-js/jest.config.js @@ -3,7 +3,7 @@ const config = { displayName: 'clerk-js', injectGlobals: true, - testEnvironment: '/jsdom-with-timezone.ts', + testEnvironment: '/jest.jsdom-with-timezone.ts', roots: ['/src'], setupFiles: ['./jest.setup.ts'], setupFilesAfterEnv: ['./jest.setup-after-env.ts'], diff --git a/packages/clerk-js/jsdom-with-timezone.ts b/packages/clerk-js/jest.jsdom-with-timezone.ts similarity index 100% rename from packages/clerk-js/jsdom-with-timezone.ts rename to packages/clerk-js/jest.jsdom-with-timezone.ts diff --git a/packages/clerk-js/turbo.json b/packages/clerk-js/turbo.json index 777ad057889..07391097f92 100644 --- a/packages/clerk-js/turbo.json +++ b/packages/clerk-js/turbo.json @@ -3,32 +3,66 @@ "pipeline": { "build": { "inputs": [ - "src/**", - "headless/**", + "*.d.ts", + "**/package.json", "bundlewatch.config.json", + "headless/**", + "src/**", "tsconfig.json", + "tsconfig.build.json", "tsconfig.declarations.json", + "tsup.config.ts", "webpack.config.js", + "!**/**/*.test.*", "!**/test/**", "!**/tests/**", "!**/__tests__/**", "!**/__mocks__/**", "!**/__snapshots__/**", - "!coverage/**" + "!coverage/**", + "!examples/**", + "!node_modules/**" ] }, "test": { "inputs": [ - "src/**", - "headless/**", + "*.d.ts", + "**/package.json", + "bundlewatch.config.json", "jest.*", + "src/**", "svgTransform.js", + "tests/**", + "tsconfig.json", + "tsconfig.*.json", + "tsup.config.ts", "webpack.config.js", + + "!**/__snapshots__/**", + "!coverage/**", + "!examples/**", + "!node_modules/**" + ] + }, + "test:ci": { + "dependsOn": ["build"], + "inputs": [ + "*.d.ts", + "**/package.json", + "bundlewatch.config.json", + "jest.*", + "src/**", + "tests/**", "tsconfig.json", - "tsconfig.test.json", + "tsconfig.*.json", + "tsup.config.ts", + "webpack.config.js", + "!**/__snapshots__/**", - "!coverage/**" + "!coverage/**", + "!examples/**", + "!node_modules/**" ] } } diff --git a/packages/fastify/turbo.json b/packages/fastify/turbo.json deleted file mode 100644 index aee16686bd9..00000000000 --- a/packages/fastify/turbo.json +++ /dev/null @@ -1,20 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": [ - "src/**", - "tsup.config.ts", - "tsconfig.json", - "!**/**/*.test.*", - "!**/test/**", - "!**/__mocks__/**", - "!**/__snapshots__/**", - "!coverage/**" - ] - }, - "test": { - "inputs": ["src/**", "jest.*", "tsup.config.ts", "tsconfig.json", "!**/__snapshots__/**", "!coverage/**"] - } - } -} diff --git a/packages/nextjs/turbo.json b/packages/nextjs/turbo.json deleted file mode 100644 index 83d85a35ecd..00000000000 --- a/packages/nextjs/turbo.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": [ - "**/package.json", - "src/**", - "!examples/**", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - "!**/**/*.test.*", - "!**/test/**", - "!**/tests/**", - "!**/__tests__/**", - "!**/__mocks__/**", - "!**/__snapshots__/**" - ] - }, - "test": { - "inputs": ["src/**", "jest.*", "tsup.config.ts", "tsconfig.*", "!**/__snapshots__/**", "!coverage/**"] - } - } -} diff --git a/packages/react/turbo.json b/packages/react/turbo.json deleted file mode 100644 index d2e77c63896..00000000000 --- a/packages/react/turbo.json +++ /dev/null @@ -1,31 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": [ - "src/**", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - "!**/**/*.test.*", - "!**/test/**", - "!**/tests/**", - "!**/__tests__/**", - "!**/__mocks__/**", - "!**/__snapshots__/**", - "!coverage/**" - ] - }, - "test": { - "inputs": [ - "src/**", - "jest.*", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.*.json", - "!**/__snapshots__/**", - "!coverage/**" - ] - } - } -} diff --git a/packages/remix/turbo.json b/packages/remix/turbo.json deleted file mode 100644 index d2e77c63896..00000000000 --- a/packages/remix/turbo.json +++ /dev/null @@ -1,31 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": [ - "src/**", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - "!**/**/*.test.*", - "!**/test/**", - "!**/tests/**", - "!**/__tests__/**", - "!**/__mocks__/**", - "!**/__snapshots__/**", - "!coverage/**" - ] - }, - "test": { - "inputs": [ - "src/**", - "jest.*", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.*.json", - "!**/__snapshots__/**", - "!coverage/**" - ] - } - } -} diff --git a/packages/sdk-node/turbo.json b/packages/sdk-node/turbo.json index aae5e901453..ecf7ee4b7f0 100644 --- a/packages/sdk-node/turbo.json +++ b/packages/sdk-node/turbo.json @@ -3,29 +3,25 @@ "pipeline": { "build": { "inputs": [ + "*.d.ts", + "**/package.json", + "cjs/**", + "esm/**", "src/**", "scripts/**", - "tsup.config.ts", "tsconfig.json", "tsconfig.declarations.json", + "tsup.config.ts", + "!**/**/*.test.*", "!**/test/**", "!**/tests/**", "!**/__tests__/**", "!**/__mocks__/**", "!**/__snapshots__/**", - "!coverage/**" - ] - }, - "test": { - "inputs": [ - "src/**", - "jest.*", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.*.json", - "!**/__snapshots__/**", - "!coverage/**" + "!coverage/**", + "!examples/**", + "!node_modules/**" ] } } diff --git a/packages/shared/turbo.json b/packages/shared/turbo.json deleted file mode 100644 index a426177a8ca..00000000000 --- a/packages/shared/turbo.json +++ /dev/null @@ -1,33 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": [ - "src/**", - "global.d.ts", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.declarations.json", - "!**/**/*.test.*", - "!**/test/**", - "!**/tests/**", - "!**/__tests__/**", - "!**/__mocks__/**", - "!**/__snapshots__/**", - "!coverage/**" - ] - }, - "test": { - "inputs": [ - "src/**", - "jest.*", - "global.d.ts", - "tsup.config.ts", - "tsconfig.json", - "tsconfig.*.json", - "!**/__snapshots__/**", - "!coverage/**" - ] - } - } -} diff --git a/packages/themes/turbo.json b/packages/themes/turbo.json deleted file mode 100644 index 04b16095e1c..00000000000 --- a/packages/themes/turbo.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": ["src/**", "tsconfig.json", "tsconfig.buid.json"] - } - } -} diff --git a/packages/types/turbo.json b/packages/types/turbo.json deleted file mode 100644 index e8b84233f83..00000000000 --- a/packages/types/turbo.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "extends": ["//"], - "pipeline": { - "build": { - "inputs": ["src/**", "tsconfig.*"] - } - } -} diff --git a/turbo.json b/turbo.json index 025ebad9bdb..d3425be9ce3 100644 --- a/turbo.json +++ b/turbo.json @@ -25,11 +25,32 @@ "RUNNER_ARCH", "RUNNER_DEBUG", "RUNNER_OS", + "TZ", "VERCEL" ], "pipeline": { "build": { "dependsOn": ["^build"], + "inputs": [ + "*.d.ts", + "**/package.json", + "bundlewatch.config.json", + "src/**", + "tsconfig.json", + "tsconfig.build.json", + "tsconfig.declarations.json", + "tsup.config.ts", + + "!**/**/*.test.*", + "!**/test/**", + "!**/tests/**", + "!**/__tests__/**", + "!**/__mocks__/**", + "!**/__snapshots__/**", + "!coverage/**", + "!examples/**", + "!node_modules/**" + ], "outputMode": "new-only", "outputs": ["dist/**"] }, @@ -48,11 +69,43 @@ }, "test": { "dependsOn": ["build"], + "inputs": [ + "*.d.ts", + "**/package.json", + "bundlewatch.config.json", + "jest.*", + "src/**", + "tests/**", + "tsconfig.json", + "tsconfig.*.json", + "tsup.config.ts", + + "!**/__snapshots__/**", + "!coverage/**", + "!examples/**", + "!node_modules/**" + ], "outputMode": "new-only", "outputs": [] }, "test:ci": { "dependsOn": ["build"], + "inputs": [ + "*.d.ts", + "**/package.json", + "bundlewatch.config.json", + "jest.*", + "src/**", + "tests/**", + "tsconfig.json", + "tsconfig.*.json", + "tsup.config.ts", + + "!**/__snapshots__/**", + "!coverage/**", + "!examples/**", + "!node_modules/**" + ], "outputMode": "new-only", "outputs": [] }, From a4213bf39cdd879933ddfff549b01e2ca53ae693 Mon Sep 17 00:00:00 2001 From: Tom Milewski Date: Sun, 15 Oct 2023 17:06:44 -0400 Subject: [PATCH 3/3] chore(clerk-react,shared): Temp fix for ESLint errors --- .changeset/perfect-dots-doubt.md | 2 ++ packages/backend/src/tokens/factory.ts | 1 + .../src/components/controlComponents.tsx | 4 ++-- .../react/src/components/uiComponents.tsx | 24 ++++++++++++------- packages/react/src/isomorphicClerk.ts | 6 ++++- packages/react/src/utils/loadClerkJsScript.ts | 1 + packages/shared/src/hooks/useOrganization.tsx | 6 ++++- 7 files changed, 32 insertions(+), 12 deletions(-) create mode 100644 .changeset/perfect-dots-doubt.md diff --git a/.changeset/perfect-dots-doubt.md b/.changeset/perfect-dots-doubt.md new file mode 100644 index 00000000000..a845151cc84 --- /dev/null +++ b/.changeset/perfect-dots-doubt.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/packages/backend/src/tokens/factory.ts b/packages/backend/src/tokens/factory.ts index a3a640c276f..9a7a665b21e 100644 --- a/packages/backend/src/tokens/factory.ts +++ b/packages/backend/src/tokens/factory.ts @@ -106,6 +106,7 @@ export function createAuthenticateRequest(params: CreateAuthenticateRequestOptio publishableKey: runtimePublishableKey || buildtimePublishableKey, proxyUrl: runtimeProxyUrl || buildProxyUrl, isSatellite: runtimeIsSatellite || buildtimeIsSatellite, + // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion domain: (runtimeDomain || buildtimeDomain) as any, userAgent: runtimeUserAgent || buildUserAgent, }); diff --git a/packages/react/src/components/controlComponents.tsx b/packages/react/src/components/controlComponents.tsx index 20791102102..061dd3a6f64 100644 --- a/packages/react/src/components/controlComponents.tsx +++ b/packages/react/src/components/controlComponents.tsx @@ -42,8 +42,8 @@ export const ClerkLoading = ({ children }: React.PropsWithChildren): JS export const RedirectToSignIn = withClerk(({ clerk, ...props }: WithClerkProp) => { const { client, session } = clerk; - // TODO: Remove temp use of __unstable__environment - const { __unstable__environment } = clerk as any; + // @ts-expect-error - TODO: Remove temp use of __unstable__environment + const { __unstable__environment } = clerk; const hasActiveSessions = client.activeSessions && client.activeSessions.length > 0; diff --git a/packages/react/src/components/uiComponents.tsx b/packages/react/src/components/uiComponents.tsx index ca9af9043dd..930f6070f8d 100644 --- a/packages/react/src/components/uiComponents.tsx +++ b/packages/react/src/components/uiComponents.tsx @@ -72,7 +72,8 @@ export const SignIn = withClerk(({ clerk, ...props }: WithClerkProp ); @@ -83,7 +84,8 @@ export const SignUp = withClerk(({ clerk, ...props }: WithClerkProp ); @@ -94,7 +96,8 @@ export const UserProfile = withClerk(({ clerk, ...props }: WithClerkProp ); @@ -105,7 +108,8 @@ export const UserButton = withClerk(({ clerk, ...props }: WithClerkProp ); @@ -116,7 +120,8 @@ export const OrganizationProfile = withClerk(({ clerk, ...props }: WithClerkProp ); @@ -127,7 +132,8 @@ export const CreateOrganization = withClerk(({ clerk, ...props }: WithClerkProp< ); @@ -138,7 +144,8 @@ export const OrganizationSwitcher = withClerk(({ clerk, ...props }: WithClerkPro ); @@ -149,7 +156,8 @@ export const OrganizationList = withClerk(({ clerk, ...props }: WithClerkProp ); diff --git a/packages/react/src/isomorphicClerk.ts b/packages/react/src/isomorphicClerk.ts index d51e2a93d1c..4fbcd516338 100644 --- a/packages/react/src/isomorphicClerk.ts +++ b/packages/react/src/isomorphicClerk.ts @@ -732,7 +732,11 @@ export default class IsomorphicClerk { signOutCallbackOrOptions?: SignOutCallback | SignOutOptions, options?: SignOutOptions, ): Promise => { - const callback = () => this.clerkjs?.signOut(signOutCallbackOrOptions as any, options); + const callback = + typeof signOutCallbackOrOptions === 'function' + ? () => this.clerkjs?.signOut(signOutCallbackOrOptions, options) + : () => this.clerkjs?.signOut(signOutCallbackOrOptions); + if (this.clerkjs && this.#loaded) { return callback() as Promise; } else { diff --git a/packages/react/src/utils/loadClerkJsScript.ts b/packages/react/src/utils/loadClerkJsScript.ts index 1ce63f52eb4..775274dcdcf 100644 --- a/packages/react/src/utils/loadClerkJsScript.ts +++ b/packages/react/src/utils/loadClerkJsScript.ts @@ -12,6 +12,7 @@ type LoadClerkJsScriptOptions = Omit { const { frontendApi, publishableKey } = opts; diff --git a/packages/shared/src/hooks/useOrganization.tsx b/packages/shared/src/hooks/useOrganization.tsx index 3c27babf3c6..f8ab32b6555 100644 --- a/packages/shared/src/hooks/useOrganization.tsx +++ b/packages/shared/src/hooks/useOrganization.tsx @@ -1,4 +1,5 @@ import type { + ActiveSessionResource, ClerkPaginationParams, GetDomainsParams, GetInvitationsParams, @@ -365,7 +366,10 @@ export const useOrganization: UseOrganization = params => { isLoaded: !isMembershipsLoading && !isInvitationsLoading, organization, membershipList, - membership: getCurrentOrganizationMembership(session!.user.organizationMemberships, organization.id), // your membership in the current org + membership: getCurrentOrganizationMembership( + (session as ActiveSessionResource).user.organizationMemberships, + organization.id, + ), // your membership in the current org invitationList, unstable__mutate: () => { void mutateMembershipList();