From 739e781d014ba8c3ab768cbee24e362136691f8e Mon Sep 17 00:00:00 2001 From: Dimitris Klouvas Date: Thu, 28 Mar 2024 16:49:18 +0200 Subject: [PATCH] fix(clerk-js): Legacy integration tokens should not set __session cookie Legacy integration or jwt template tokens are not meant to be stored as __session cookie. They should be explicitly retrieved and used as Authorization header. --- .changeset/large-clouds-flash.md | 5 +++++ packages/clerk-js/src/core/resources/Session.ts | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 .changeset/large-clouds-flash.md diff --git a/.changeset/large-clouds-flash.md b/.changeset/large-clouds-flash.md new file mode 100644 index 00000000000..04dc8899fe2 --- /dev/null +++ b/.changeset/large-clouds-flash.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Fix setting session cookie with Legacy integration token. diff --git a/packages/clerk-js/src/core/resources/Session.ts b/packages/clerk-js/src/core/resources/Session.ts index 438286a6e26..e496715f8be 100644 --- a/packages/clerk-js/src/core/resources/Session.ts +++ b/packages/clerk-js/src/core/resources/Session.ts @@ -15,8 +15,7 @@ import type { import { unixEpochToDate } from '../../utils/date'; import { eventBus, events } from '../events'; import { SessionTokenCache } from '../tokenCache'; -import { PublicUserData } from './internal'; -import { BaseResource, Token, User } from './internal'; +import { BaseResource, PublicUserData, Token, User } from './internal'; export class Session extends BaseResource implements SessionResource { pathRoot = '/client/sessions'; @@ -146,7 +145,6 @@ export class Session extends BaseResource implements SessionResource { tokenResolver, }); return tokenResolver.then(token => { - eventBus.dispatch(events.TokenUpdate, { token }); return token.getRawString(); }); };