From 1ac929c6e53814e2d6ca279d30e9e51077da8b86 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Thu, 6 Feb 2025 09:32:37 -0500 Subject: [PATCH 1/3] fix(clerk-js): Ensure `componentProps` is defined before accessing routing --- packages/clerk-js/src/ui/lazyModules/providers.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/clerk-js/src/ui/lazyModules/providers.tsx b/packages/clerk-js/src/ui/lazyModules/providers.tsx index 4061551d989..52c27d521f5 100644 --- a/packages/clerk-js/src/ui/lazyModules/providers.tsx +++ b/packages/clerk-js/src/ui/lazyModules/providers.tsx @@ -57,7 +57,7 @@ type LazyComponentRendererProps = React.PropsWithChildren< type PortalProps = Parameters[0]; export const LazyComponentRenderer = (props: LazyComponentRendererProps) => { - if (props.componentProps.routing === 'virtual') { + if (props.componentProps?.routing === 'virtual') { deprecated('routing="virtual"', 'Use routing="hash" instead.'); } return ( From 54b960730fca3720dd06b638f728e872601accc5 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Thu, 6 Feb 2025 09:35:49 -0500 Subject: [PATCH 2/3] add changeset --- .changeset/perfect-carrots-arrive.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/perfect-carrots-arrive.md diff --git a/.changeset/perfect-carrots-arrive.md b/.changeset/perfect-carrots-arrive.md new file mode 100644 index 00000000000..d5153b5833c --- /dev/null +++ b/.changeset/perfect-carrots-arrive.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Fix issue accessing routing option when componentProps is undefined. From 90da8df9186a5f266281dc1a5fca0e3402bddbe6 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Thu, 6 Feb 2025 10:14:02 -0500 Subject: [PATCH 3/3] Update packages/clerk-js/src/ui/lazyModules/providers.tsx --- packages/clerk-js/src/ui/lazyModules/providers.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/clerk-js/src/ui/lazyModules/providers.tsx b/packages/clerk-js/src/ui/lazyModules/providers.tsx index 52c27d521f5..0ce70597f17 100644 --- a/packages/clerk-js/src/ui/lazyModules/providers.tsx +++ b/packages/clerk-js/src/ui/lazyModules/providers.tsx @@ -57,7 +57,7 @@ type LazyComponentRendererProps = React.PropsWithChildren< type PortalProps = Parameters[0]; export const LazyComponentRenderer = (props: LazyComponentRendererProps) => { - if (props.componentProps?.routing === 'virtual') { + if (props?.componentProps?.routing === 'virtual') { deprecated('routing="virtual"', 'Use routing="hash" instead.'); } return (