From 80ec5de7041359ee73ea4ee49eca7ef50986294a Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Thu, 6 Feb 2025 11:29:29 -0500 Subject: [PATCH 1/4] feat(clerk-js,types): Add menuButtonEllipsis descriptor --- packages/clerk-js/src/ui/customizables/elementDescriptors.ts | 1 + packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx | 3 ++- packages/types/src/appearance.ts | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/clerk-js/src/ui/customizables/elementDescriptors.ts b/packages/clerk-js/src/ui/customizables/elementDescriptors.ts index 3e0101c9e37..3ebc8557552 100644 --- a/packages/clerk-js/src/ui/customizables/elementDescriptors.ts +++ b/packages/clerk-js/src/ui/customizables/elementDescriptors.ts @@ -222,6 +222,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([ 'selectOption', 'menuButton', + 'menuButtonEllipsis', 'menuList', 'menuItem', diff --git a/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx b/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx index 6e55ba7c2dc..d6e5d411319 100644 --- a/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx +++ b/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx @@ -1,7 +1,7 @@ import type { MenuId } from '@clerk/types'; import type { LocalizationKey } from '../customizables'; -import { Button, Icon } from '../customizables'; +import { Button, descriptors, Icon } from '../customizables'; import { ThreeDots } from '../icons'; import { Menu, MenuItem, MenuList, MenuTrigger } from './Menu'; @@ -33,6 +33,7 @@ export const ThreeDotsMenu = (props: ThreeDotsMenuProps) => { })} variant='ghost' colorScheme='neutral' + elementDescriptor={[descriptors.menuButton, descriptors.menuButtonEllipsis]} > ; menuButton: WithOptions; + menuButtonEllipsis: WithOptions; menuList: WithOptions; menuItem: WithOptions; From 0b872cdd2f00ef668aec6850c9b4d1991745feb7 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Thu, 6 Feb 2025 11:35:17 -0500 Subject: [PATCH 2/4] add changeset --- .changeset/heavy-eggs-deliver.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/heavy-eggs-deliver.md diff --git a/.changeset/heavy-eggs-deliver.md b/.changeset/heavy-eggs-deliver.md new file mode 100644 index 00000000000..642e05a34b3 --- /dev/null +++ b/.changeset/heavy-eggs-deliver.md @@ -0,0 +1,6 @@ +--- +'@clerk/clerk-js': patch +'@clerk/types': patch +--- + +Add `menuButtonEllipsis` element descriptor. From 0391fe8a2a0693159e8734a38c43f5c00041d8fc Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Fri, 7 Feb 2025 09:19:09 -0500 Subject: [PATCH 3/4] rename --- .changeset/heavy-eggs-deliver.md | 2 +- packages/clerk-js/src/ui/customizables/elementDescriptors.ts | 2 +- packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx | 2 +- packages/types/src/appearance.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.changeset/heavy-eggs-deliver.md b/.changeset/heavy-eggs-deliver.md index 642e05a34b3..001f8ec535d 100644 --- a/.changeset/heavy-eggs-deliver.md +++ b/.changeset/heavy-eggs-deliver.md @@ -3,4 +3,4 @@ '@clerk/types': patch --- -Add `menuButtonEllipsis` element descriptor. +Add `menuButtonMoreOptions` element descriptor. diff --git a/packages/clerk-js/src/ui/customizables/elementDescriptors.ts b/packages/clerk-js/src/ui/customizables/elementDescriptors.ts index 3ebc8557552..9f3ee08570d 100644 --- a/packages/clerk-js/src/ui/customizables/elementDescriptors.ts +++ b/packages/clerk-js/src/ui/customizables/elementDescriptors.ts @@ -222,7 +222,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([ 'selectOption', 'menuButton', - 'menuButtonEllipsis', + 'menuButtonMoreOptions', 'menuList', 'menuItem', diff --git a/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx b/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx index d6e5d411319..e0ce0110cf4 100644 --- a/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx +++ b/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx @@ -33,7 +33,7 @@ export const ThreeDotsMenu = (props: ThreeDotsMenuProps) => { })} variant='ghost' colorScheme='neutral' - elementDescriptor={[descriptors.menuButton, descriptors.menuButtonEllipsis]} + elementDescriptor={[descriptors.menuButton, descriptors.menuButtonMoreOptions]} > ; menuButton: WithOptions; - menuButtonEllipsis: WithOptions; + menuButtonMoreOptions: WithOptions; menuList: WithOptions; menuItem: WithOptions; From 5ba6a4fcdac04b199ee94bee90585bc04fbeb0b3 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Fri, 7 Feb 2025 10:39:24 -0500 Subject: [PATCH 4/4] Revert "rename" This reverts commit 0391fe8a2a0693159e8734a38c43f5c00041d8fc. --- .changeset/heavy-eggs-deliver.md | 2 +- packages/clerk-js/src/ui/customizables/elementDescriptors.ts | 2 +- packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx | 2 +- packages/types/src/appearance.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.changeset/heavy-eggs-deliver.md b/.changeset/heavy-eggs-deliver.md index 001f8ec535d..642e05a34b3 100644 --- a/.changeset/heavy-eggs-deliver.md +++ b/.changeset/heavy-eggs-deliver.md @@ -3,4 +3,4 @@ '@clerk/types': patch --- -Add `menuButtonMoreOptions` element descriptor. +Add `menuButtonEllipsis` element descriptor. diff --git a/packages/clerk-js/src/ui/customizables/elementDescriptors.ts b/packages/clerk-js/src/ui/customizables/elementDescriptors.ts index 9f3ee08570d..3ebc8557552 100644 --- a/packages/clerk-js/src/ui/customizables/elementDescriptors.ts +++ b/packages/clerk-js/src/ui/customizables/elementDescriptors.ts @@ -222,7 +222,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([ 'selectOption', 'menuButton', - 'menuButtonMoreOptions', + 'menuButtonEllipsis', 'menuList', 'menuItem', diff --git a/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx b/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx index e0ce0110cf4..d6e5d411319 100644 --- a/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx +++ b/packages/clerk-js/src/ui/elements/ThreeDotsMenu.tsx @@ -33,7 +33,7 @@ export const ThreeDotsMenu = (props: ThreeDotsMenuProps) => { })} variant='ghost' colorScheme='neutral' - elementDescriptor={[descriptors.menuButton, descriptors.menuButtonMoreOptions]} + elementDescriptor={[descriptors.menuButton, descriptors.menuButtonEllipsis]} > ; menuButton: WithOptions; - menuButtonMoreOptions: WithOptions; + menuButtonEllipsis: WithOptions; menuList: WithOptions; menuItem: WithOptions;