From fb2508a603df789d88dec04d96cb410ab337f1c9 Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Fri, 28 Mar 2025 14:04:12 +0200 Subject: [PATCH 1/3] fix(clerk-js): Prepare first factor wasn't triggered for same factor afte sign out --- .../components/SignIn/SignInFactorOneCodeForm.tsx | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx index b0c4b5f988c..a9b189029a5 100644 --- a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx +++ b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx @@ -55,16 +55,15 @@ export const SignInFactorOneCodeForm = (props: SignInFactorOneCodeFormProps) => }; useFetch( - shouldAvoidPrepare - ? undefined - : () => - signIn - ?.prepareFirstFactor(props.factor) - .then(() => props.onFactorPrepare()) - .catch(err => handleError(err, [], card.setError)), + () => + signIn + ?.prepareFirstFactor(props.factor) + .then(() => props.onFactorPrepare()) + .catch(err => handleError(err, [], card.setError)), { name: 'signIn.prepareFirstFactor', factor: props.factor, + id: signIn.id, }, { staleTime: 100, From 641133fd5b00b76de979ecadcc85eb56068d32aa Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Fri, 28 Mar 2025 14:06:46 +0200 Subject: [PATCH 2/3] chore(repo): Adds changeset --- .changeset/poor-lights-look.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/poor-lights-look.md diff --git a/.changeset/poor-lights-look.md b/.changeset/poor-lights-look.md new file mode 100644 index 00000000000..ecd3811b465 --- /dev/null +++ b/.changeset/poor-lights-look.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Fix sign in prepare first factor cache key From e7906cfdddcd8ee705a162fb186600cbe6700e4b Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Fri, 28 Mar 2025 14:10:48 +0200 Subject: [PATCH 3/3] fix(clerk-js): Rollback accidentally pushed chgange --- .../ui/components/SignIn/SignInFactorOneCodeForm.tsx | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx index a9b189029a5..15503cb3346 100644 --- a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx +++ b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOneCodeForm.tsx @@ -55,11 +55,13 @@ export const SignInFactorOneCodeForm = (props: SignInFactorOneCodeFormProps) => }; useFetch( - () => - signIn - ?.prepareFirstFactor(props.factor) - .then(() => props.onFactorPrepare()) - .catch(err => handleError(err, [], card.setError)), + shouldAvoidPrepare + ? undefined + : () => + signIn + ?.prepareFirstFactor(props.factor) + .then(() => props.onFactorPrepare()) + .catch(err => handleError(err, [], card.setError)), { name: 'signIn.prepareFirstFactor', factor: props.factor,