Skip to content

fix(clerk-js,types): Add keys targeting avatar buttons#1455

Merged
tmilewski merged 3 commits into
mainfrom
tom/usr-98
Jul 11, 2023
Merged

fix(clerk-js,types): Add keys targeting avatar buttons#1455
tmilewski merged 3 commits into
mainfrom
tom/usr-98

Conversation

@tmilewski

@tmilewski tmilewski commented Jul 5, 2023

Copy link
Copy Markdown
Member

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

Enables the ability to target the Avatar upload and remove action buttons.

Fixes USR-98

@changeset-bot

changeset-bot Bot commented Jul 5, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3b4dfed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jit-ci jit-ci Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@nikosdouvlis
nikosdouvlis requested a review from desiprisg July 6, 2023 08:43
@desiprisg

desiprisg commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Can we check if the same issue exists for org logo upload/remove?
Edit: nevermind, we use the same component :D

Comment thread packages/types/src/appearance.ts Outdated
Enables the ability to target the Avatar upload and remove action
buttons. Fixes USR-98
@tmilewski
tmilewski merged commit 6dfcb90 into main Jul 11, 2023
@tmilewski
tmilewski deleted the tom/usr-98 branch July 11, 2023 15:05
@clerk-cookie clerk-cookie mentioned this pull request Jul 11, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants