chore(shared): Deprecate useOrganizations#1466
Merged
Merged
Conversation
panteliselef
requested review from
SokratisVidros and
nikosdouvlis
as code owners
July 9, 2023 17:47
🦋 Changeset detectedLatest commit: 85b0ac8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
approved these changes
Jul 10, 2023
anagstef
approved these changes
Jul 10, 2023
nikosdouvlis
approved these changes
Jul 10, 2023
nikosdouvlis
left a comment
nikosdouvlis
left a comment
Member
There was a problem hiding this comment.
Might have a minor typo, other than that this LGTM
| '@clerk/shared': minor | ||
| --- | ||
|
|
||
| Deprecate the `useOrganization` react hook. The hook can be replaced from useClerk, useOrganization, useOrganizationList |
Member
There was a problem hiding this comment.
Should this be useOrganizations?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this one
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.The
useOrganizationsonly contains logic that can be directly exported fromuseClerk()anduseOrganizationanduseOrganizationListcan be used as replacement with more functionality and better DX