Skip to content

fix(backend): Access the correct headers to determine the Response Content-Type#1469

Merged
nikosdouvlis merged 1 commit into
mainfrom
stefanos/js-522-backend-the-request-function-checks-the-wrong-headers
Jul 12, 2023
Merged

fix(backend): Access the correct headers to determine the Response Content-Type#1469
nikosdouvlis merged 1 commit into
mainfrom
stefanos/js-522-backend-the-request-function-checks-the-wrong-headers

Conversation

@anagstef

Copy link
Copy Markdown
Contributor

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

This PR introduces a small fix for the Response Headers Content-Type check.

@anagstef
anagstef requested a review from dimkl July 11, 2023 09:52
@anagstef anagstef self-assigned this Jul 11, 2023
@changeset-bot

changeset-bot Bot commented Jul 11, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 22f3292

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jit-ci jit-ci Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@anagstef
anagstef force-pushed the stefanos/js-522-backend-the-request-function-checks-the-wrong-headers branch from 38db32a to f1b3063 Compare July 11, 2023 10:16
Comment thread packages/backend/src/api/request.ts Outdated
Comment thread packages/backend/src/api/request.ts Outdated
@anagstef
anagstef force-pushed the stefanos/js-522-backend-the-request-function-checks-the-wrong-headers branch from f1b3063 to 50da715 Compare July 12, 2023 10:48
@anagstef
anagstef force-pushed the stefanos/js-522-backend-the-request-function-checks-the-wrong-headers branch from 50da715 to 22f3292 Compare July 12, 2023 10:55
@nikosdouvlis
nikosdouvlis merged commit e303684 into main Jul 12, 2023
@nikosdouvlis
nikosdouvlis deleted the stefanos/js-522-backend-the-request-function-checks-the-wrong-headers branch July 12, 2023 11:13
@clerk-cookie clerk-cookie mentioned this pull request Jul 12, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants