fix(clerk-js): In <CreateOrganization /> skip invitation page if max allowed memberships equal 1#1471
Merged
chanioxaris merged 2 commits intoJul 12, 2023
Conversation
…allowed memberships equal 1 This commit modifies the logic of the <CreateOrganization /> component to handle the case the newly create organization has max allowed memberships equal to 1. In this case, we shouldn't render the invitation page, as the user can't invite any more members, and they will need to skip it either way
chanioxaris
requested review from
SokratisVidros and
nikosdouvlis
as code owners
July 11, 2023 13:17
🦋 Changeset detectedLatest commit: b63adb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chanioxaris
changed the title
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
panteliselef
approved these changes
Jul 12, 2023
panteliselef
left a comment
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
Looks good + improves the UX 💯
nikosdouvlis
approved these changes
Jul 12, 2023
…eorganization-if-org-max
chanioxaris
deleted the
haris/org-49-skip-invitation-screen-in-createorganization-if-org-max
branch
July 12, 2023 11:56
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This commit modifies the logic of the component to handle the case the newly create organization has max allowed memberships equal to 1. In this case, we shouldn't render the invitation page, as the user can't invite any more members, and they will need to skip it either way
Before
after.mov
After
before.mov