Skip to content

feat(backend,clerk-js,types): Support the new LinkedIn OAuth Provider - #1772

Merged
fragoulis merged 1 commit into
mainfrom
fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider
Oct 10, 2023
Merged

feat(backend,clerk-js,types): Support the new LinkedIn OAuth Provider#1772
fragoulis merged 1 commit into
mainfrom
fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider

Conversation

@fragoulis

Copy link
Copy Markdown
Contributor

Description

LinkedIn has changed the OAuth flow by replacing it with OpenID Connect. We have already added support for this in the backend.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@fragoulis
fragoulis requested a review from a team as a code owner September 25, 2023 08:47
@changeset-bot

changeset-bot Bot commented Sep 25, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7d8425

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Minor
@clerk/backend Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/localizations Patch
@clerk/clerk-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fragoulis
fragoulis force-pushed the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch from 0ec5bf3 to a929d10 Compare September 25, 2023 08:50
@fragoulis
fragoulis force-pushed the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch from 097f346 to 0b4094a Compare September 25, 2023 09:39
Comment thread packages/types/src/oauth.ts Outdated
Comment thread packages/types/src/oauth.ts Outdated
LinkedIn has changed the OAuth flow by replacing it with OpenID Connect.
We have already added support for this in the backend.
@fragoulis
fragoulis force-pushed the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch from 14519a0 to c7d8425 Compare October 10, 2023 10:42
@fragoulis

fragoulis commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

This is ready. The new provider's name will be set in dashboard, as well as whether a user can enable only one of these.

@fragoulis
fragoulis added this pull request to the merge queue Oct 10, 2023
provider: 'linkedin_oidc',
strategy: 'oauth_linkedin_oidc',
name: 'LinkedIn',
docsUrl: 'https://clerk.com/docs/authentication/social-connections/linkedin-oidc',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist yet, right? Are we adding it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged via the queue into main with commit 9101488 Oct 10, 2023
@fragoulis
fragoulis deleted the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch October 10, 2023 11:56
@clerk-cookie clerk-cookie mentioned this pull request Oct 10, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants