Skip to content

chore(shared): Remove patch for swr-devtools - #1794

Merged
dimkl merged 1 commit into
mainfrom
ORG-232
Sep 28, 2023
Merged

chore(shared): Remove patch for swr-devtools#1794
dimkl merged 1 commit into
mainfrom
ORG-232

Conversation

@panteliselef

@panteliselef panteliselef commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

Description

Our patch was preventing swr-devtools from running with the react version the clerkjs components use, causing the hosting app to break.

This has now been patched from the maintainer of swr-devtools and in a setup where both patches run the devtools will alway be disabled.

This PR removes our patch and allows swr-devtools to run only for the hosting app (not hotloaded clerkjs components)

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@panteliselef
panteliselef requested a review from a team as a code owner September 28, 2023 09:53
@panteliselef panteliselef self-assigned this Sep 28, 2023
@changeset-bot

changeset-bot Bot commented Sep 28, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3bbf63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@clerk/shared Patch
@clerk/clerk-js Patch
@clerk/fastify Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 0.4.3-snapshot.3bbf63f
@clerk/clerk-js 4.58.3-snapshot.3bbf63f
@clerk/clerk-expo 0.19.5-snapshot.3bbf63f
@clerk/fastify 0.6.10-snapshot.3bbf63f
gatsby-plugin-clerk 4.4.11-snapshot.3bbf63f
@clerk/nextjs 4.24.3-snapshot.3bbf63f
@clerk/clerk-react 4.25.3-snapshot.3bbf63f
@clerk/remix 3.0.2-snapshot.3bbf63f
@clerk/shared 0.23.2-snapshot.3bbf63f

Tip: use the snippet copy button below to quickly install the required packages.

# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.4.3-snapshot.3bbf63f
# @clerk/clerk-js
npm i @clerk/clerk-js@4.58.3-snapshot.3bbf63f
# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.5-snapshot.3bbf63f
# @clerk/fastify
npm i @clerk/fastify@0.6.10-snapshot.3bbf63f
# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.11-snapshot.3bbf63f
# @clerk/nextjs
npm i @clerk/nextjs@4.24.3-snapshot.3bbf63f
# @clerk/clerk-react
npm i @clerk/clerk-react@4.25.3-snapshot.3bbf63f
# @clerk/remix
npm i @clerk/remix@3.0.2-snapshot.3bbf63f
# @clerk/shared
npm i @clerk/shared@0.23.2-snapshot.3bbf63f

@panteliselef panteliselef changed the title [WIP] chore(shared): Remove patch for swr-devtools chore(shared): Remove patch for swr-devtools Sep 28, 2023
@dimkl
dimkl added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 753f7bb Sep 28, 2023
@dimkl
dimkl deleted the ORG-232 branch September 28, 2023 10:24
@clerk-cookie clerk-cookie mentioned this pull request Sep 28, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants