chore(*): Rename refs of MagicLink to EmailLink - deprecation warnings - #1836
Merged
Conversation
🦋 Changeset detectedLatest commit: 2f66fe8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
js-643-rename-magiclink-js-docs
branch
2 times, most recently
from
October 6, 2023 21:18
a141709 to
335e105
Compare
dimkl
force-pushed
the
js-643-rename-magiclink-deprecated
branch
from
October 7, 2023 17:26
681e8a5 to
d1811bb
Compare
panteliselef
approved these changes
Oct 9, 2023
| Expired: 'expired', | ||
| Failed: 'failed', | ||
| }; | ||
| // TODO(@dimkl): Add deprecation warning for MagicLinkErrorCode |
Contributor
Author
There was a problem hiding this comment.
i will update the current PR. I am trying to find if we could avoid adding a deprecation warning for this (eg it may not be exported or there is no real usage outside of our own SDKs)
Contributor
Author
There was a problem hiding this comment.
@panteliselef i've added a deprecation warning for MagicLinkErrorCode since it may be used by our customers
dimkl
force-pushed
the
js-643-rename-magiclink-deprecated
branch
from
October 9, 2023 10:43
d1811bb to
479f50b
Compare
dimkl
force-pushed
the
js-643-rename-magiclink-deprecated
branch
from
October 9, 2023 13:02
479f50b to
2f66fe8
Compare
dimkl
enabled auto-merge
October 9, 2023 13:03
dimkl
added this pull request to the merge queue
Oct 9, 2023
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Warn about MagicLink deprecations:
MagicLinkErrorisMagicLinkErrorMagicLinkErrorCodehandleMagicLinkVerificationcreateMagicLinkFlowuseMagicLinkChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore