Skip to content

fix(shared): Removal of clerkError property - #1839

Merged
brkalow merged 1 commit into
mainfrom
elef/hot-fix-error-class
Oct 6, 2023
Merged

fix(shared): Removal of clerkError property#1839
brkalow merged 1 commit into
mainfrom
elef/hot-fix-error-class

Conversation

@panteliselef

@panteliselef panteliselef commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Description

This PR reverts the unintended removal of clerkError. When missing it would cause the isClerkAPIResponseError return a wrong value

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@panteliselef
panteliselef requested a review from brkalow October 6, 2023 18:41
@panteliselef panteliselef self-assigned this Oct 6, 2023
@panteliselef
panteliselef requested a review from a team as a code owner October 6, 2023 18:42
@changeset-bot

changeset-bot Bot commented Oct 6, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2e09f5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/shared Patch
@clerk/backend Patch
@clerk/clerk-js Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
gatsby-plugin-clerk Patch
@clerk/clerk-sdk-node Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef
panteliselef force-pushed the elef/hot-fix-error-class branch from 28a9dc6 to 2e09f5d Compare October 6, 2023 19:10
@panteliselef

Copy link
Copy Markdown
Contributor Author

!snapshot

@brkalow
brkalow added this pull request to the merge queue Oct 6, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 0.30.3-snapshot.2e09f5d
@clerk/chrome-extension 0.4.6-snapshot.2e09f5d
@clerk/clerk-js 4.60.1-snapshot.2e09f5d
@clerk/clerk-expo 0.19.8-snapshot.2e09f5d
@clerk/fastify 0.6.13-snapshot.2e09f5d
gatsby-plugin-clerk 4.4.14-snapshot.2e09f5d
@clerk/nextjs 4.25.3-snapshot.2e09f5d
@clerk/clerk-react 4.26.3-snapshot.2e09f5d
@clerk/remix 3.0.5-snapshot.2e09f5d
@clerk/clerk-sdk-node 4.12.12-snapshot.2e09f5d
@clerk/shared 0.24.3-snapshot.2e09f5d

Tip: use the snippet copy button below to quickly install the required packages.

# @clerk/backend
npm i @clerk/backend@0.30.3-snapshot.2e09f5d
# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.4.6-snapshot.2e09f5d
# @clerk/clerk-js
npm i @clerk/clerk-js@4.60.1-snapshot.2e09f5d
# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.8-snapshot.2e09f5d
# @clerk/fastify
npm i @clerk/fastify@0.6.13-snapshot.2e09f5d
# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.14-snapshot.2e09f5d
# @clerk/nextjs
npm i @clerk/nextjs@4.25.3-snapshot.2e09f5d
# @clerk/clerk-react
npm i @clerk/clerk-react@4.26.3-snapshot.2e09f5d
# @clerk/remix
npm i @clerk/remix@3.0.5-snapshot.2e09f5d
# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.12-snapshot.2e09f5d
# @clerk/shared
npm i @clerk/shared@0.24.3-snapshot.2e09f5d

Merged via the queue into main with commit bf66d73 Oct 6, 2023
@brkalow
brkalow deleted the elef/hot-fix-error-class branch October 6, 2023 19:27
@clerk-cookie clerk-cookie mentioned this pull request Oct 6, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants