fix(clerk-js): Enforce LTR direction in code inputs - #1873
Merged
LekoArts merged 1 commit intoOct 13, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: d3b5252 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Oct 12, 2023
Contributor
|
@desiprisg Could you add a screenshot with before/after the fix? |
Contributor
Author
done |
anagstef
approved these changes
Oct 12, 2023
anagstef
left a comment
anagstef
left a comment
Contributor
There was a problem hiding this comment.
Great job!
Should we also fix this padding here?
panteliselef
approved these changes
Oct 12, 2023
LekoArts
added this pull request to the merge queue
Oct 13, 2023
LekoArts
deleted the
george/usr-410-codenumber-are-rtl-in-component-when-using-rtl-language
branch
October 13, 2023 06:36
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
After:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore