fix(nextjs): Stop ts errors for non-static nextjs typed routes in authMiddleware - #1928
Merged
desiprisg merged 1 commit intoOct 24, 2023
Conversation
🦋 Changeset detectedLatest commit: 9a1f767 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
desiprisg
force-pushed
the
george/sdk-811-nextjs-type-is-not-assignable-to-type-regexp
branch
from
October 23, 2023 22:54
0289818 to
5d227e9
Compare
desiprisg
changed the title
desiprisg
force-pushed
the
george/sdk-811-nextjs-type-is-not-assignable-to-type-regexp
branch
from
October 23, 2023 22:59
5d227e9 to
9b9508a
Compare
desiprisg
marked this pull request as ready for review
October 23, 2023 23:01
brkalow
approved these changes
Oct 23, 2023
desiprisg
force-pushed
the
george/sdk-811-nextjs-type-is-not-assignable-to-type-regexp
branch
from
October 23, 2023 23:26
9b9508a to
9a1f767
Compare
dimkl
approved these changes
Oct 24, 2023
desiprisg
added this pull request to the merge queue
Oct 24, 2023
desiprisg
deleted the
george/sdk-811-nextjs-type-is-not-assignable-to-type-regexp
branch
October 24, 2023 00:24
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts a change in the types that caused
authMiddlewaretypes to not accept anything except static routes when using the experimental typed routes feature in nextjs.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore