From 9a0929b9d189367b52220055496f911a28922d26 Mon Sep 17 00:00:00 2001 From: Kristian Freeman Date: Fri, 20 Aug 2021 16:33:18 -0500 Subject: [PATCH 1/3] [workers/pages] Chat notif on failing builds Notify the team internally when Workers/Pages docs builds fail. --- .github/workflows/deploy.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 8bd96db29f4..15e6e57c497 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -1053,6 +1053,13 @@ jobs: workingDirectory: 'products/pages' environment: 'production' wranglerVersion: '1.13.0' + - name: Google Chat Notification + uses: Co-qn/google-chat-notification@releases/v1 + with: + name: Build + url: ${{ secrets.WDC_TEAM_GOOGLE_CHAT_WEBHOOK }} + status: ${{ job.status }} + if: job.status == "failure" deploy-page-shield: runs-on: ubuntu-latest @@ -1593,3 +1600,10 @@ jobs: workingDirectory: "products/workers" environment: "production" wranglerVersion: '1.13.0' + - name: Google Chat Notification + uses: Co-qn/google-chat-notification@releases/v1 + with: + name: Build + url: ${{ secrets.WDC_TEAM_GOOGLE_CHAT_WEBHOOK }} + status: ${{ job.status }} + if: job.status == "failure" From 39694a17f4a8b9dfe16d1a2942126247bb844dae Mon Sep 17 00:00:00 2001 From: Kristian Freeman Date: Fri, 20 Aug 2021 16:39:50 -0500 Subject: [PATCH 2/3] Update deploy.yml update with signalnerve fork --- .github/workflows/deploy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 15e6e57c497..804112d262c 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -1054,7 +1054,7 @@ jobs: environment: 'production' wranglerVersion: '1.13.0' - name: Google Chat Notification - uses: Co-qn/google-chat-notification@releases/v1 + uses: signalnerve/google-chat-notification@master with: name: Build url: ${{ secrets.WDC_TEAM_GOOGLE_CHAT_WEBHOOK }} @@ -1601,7 +1601,7 @@ jobs: environment: "production" wranglerVersion: '1.13.0' - name: Google Chat Notification - uses: Co-qn/google-chat-notification@releases/v1 + uses: signalnerve/google-chat-notification@master with: name: Build url: ${{ secrets.WDC_TEAM_GOOGLE_CHAT_WEBHOOK }} From 120266971ebdad77c449cf9481d63a98a599a1ba Mon Sep 17 00:00:00 2001 From: Kristian Freeman Date: Fri, 20 Aug 2021 16:42:19 -0500 Subject: [PATCH 3/3] Update deploy.yml Fix if conditional --- .github/workflows/deploy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 804112d262c..47e741f84a2 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -1059,7 +1059,7 @@ jobs: name: Build url: ${{ secrets.WDC_TEAM_GOOGLE_CHAT_WEBHOOK }} status: ${{ job.status }} - if: job.status == "failure" + if: ${{ failure() }} deploy-page-shield: runs-on: ubuntu-latest @@ -1606,4 +1606,4 @@ jobs: name: Build url: ${{ secrets.WDC_TEAM_GOOGLE_CHAT_WEBHOOK }} status: ${{ job.status }} - if: job.status == "failure" + if: ${{ failure() }}