Revert "feat(unenv-preset): add support for native node:sqlite module (#11805)" (#11826)

This reverts commit 47e9638.

Author: danlapid

.changeset/native-sqlite-module.md

@@ -80,7 +80,6 @@ export function getCloudflarePreset({
 	const consoleOverrides = getConsoleOverrides(compat);
 	const vmOverrides = getVmOverrides(compat);
 	const inspectorOverrides = getInspectorOverrides(compat);
-	const sqliteOverrides = getSqliteOverrides(compat);
 
 	// "dynamic" as they depend on the compatibility date and flags
 	const dynamicNativeModules = [
@@ -97,7 +96,6 @@ export function getCloudflarePreset({
 		...consoleOverrides.nativeModules,
 		...vmOverrides.nativeModules,
 		...inspectorOverrides.nativeModules,
-		...sqliteOverrides.nativeModules,
 	];
 
 	// "dynamic" as they depend on the compatibility date and flags
@@ -115,7 +113,6 @@ export function getCloudflarePreset({
 		...consoleOverrides.hybridModules,
 		...vmOverrides.hybridModules,
 		...inspectorOverrides.hybridModules,
-		...sqliteOverrides.hybridModules,
 	];
 
 	return {
@@ -638,39 +635,3 @@ function getInspectorOverrides({
 				hybridModules: [],
 			};
 }
-
-/**
- * Returns the overrides for `node:sqlite` (unenv or workerd)
- *
- * The native sqlite implementation:
- * - is experimental and has no default enable date
- * - can be enabled with the "enable_nodejs_sqlite_module" flag
- * - can be disabled with the "disable_nodejs_sqlite_module" flag
- */
-function getSqliteOverrides({
-	compatibilityFlags,
-}: {
-	compatibilityDate: string;
-	compatibilityFlags: string[];
-}): { nativeModules: string[]; hybridModules: string[] } {
-	const disabledByFlag = compatibilityFlags.includes(
-		"disable_nodejs_sqlite_module"
-	);
-
-	const enabledByFlag =
-		compatibilityFlags.includes("enable_nodejs_sqlite_module") &&
-		compatibilityFlags.includes("experimental");
-
-	const enabled = enabledByFlag && !disabledByFlag;
-
-	// When enabled, use the native `sqlite` module from workerd
-	return enabled
-		? {
-				nativeModules: ["sqlite"],
-				hybridModules: [],
-			}
-		: {
-				nativeModules: [],
-				hybridModules: [],
-			};
-}

packages/unenv-preset/src/preset.ts

@@ -429,28 +429,6 @@ const localTestConfigs: TestConfig[] = [
 			},
 		},
 	],
-	// node:sqlite (experimental, no default enable date)
-	[
-		// TODO: add test for disabled by date (no date defined yet)
-		// TODO: add test for enabled by date (no date defined yet)
-		{
-			name: "sqlite enabled by flag",
-			compatibilityDate: "2024-09-23",
-			compatibilityFlags: ["enable_nodejs_sqlite_module", "experimental"],
-			expectRuntimeFlags: {
-				enable_nodejs_sqlite_module: true,
-			},
-		},
-		// TODO: update the date past the default enable date (when defined)
-		{
-			name: "sqlite disabled by flag",
-			compatibilityDate: "2024-09-23",
-			compatibilityFlags: ["disable_nodejs_sqlite_module", "experimental"],
-			expectRuntimeFlags: {
-				enable_nodejs_sqlite_module: false,
-			},
-		},
-	],
 ].flat() as TestConfig[];
 
 describe.each(localTestConfigs)(

packages/wrangler/e2e/unenv-preset/preset.test.ts

@@ -783,44 +783,6 @@ export const WorkerdTests: Record<string, () => void> = {
 			assertTypeOf(inspectorPromises.default, "Network", "object");
 		}
 	},
-
-	async testSqlite() {
-		// @ts-expect-error TS2307 - node:sqlite is experimental and may not have type declarations
-		const sqlite = await import("node:sqlite");
-
-		// Common exports (both unenv stub and native workerd)
-		assertTypeOfProperties(sqlite, {
-			DatabaseSync: "function",
-			StatementSync: "function",
-			constants: "object",
-			default: "object",
-		});
-		assertTypeOfProperties(sqlite.default, {
-			DatabaseSync: "function",
-			StatementSync: "function",
-			constants: "object",
-		});
-
-		if (getRuntimeFlagValue("enable_nodejs_sqlite_module")) {
-			// Native workerd exports `backup` function and non-empty constants
-			assertTypeOf(sqlite, "backup", "function");
-			assertTypeOf(sqlite.default, "backup", "function");
-			assert.strictEqual(
-				"SQLITE_CHANGESET_OMIT" in sqlite.constants,
-				true,
-				"constants should contain SQLITE_CHANGESET_OMIT"
-			);
-		} else {
-			// unenv stub: no backup function and empty constants
-			assertTypeOf(sqlite, "backup", "undefined");
-			assertTypeOf(sqlite.default, "backup", "undefined");
-			assert.deepStrictEqual(
-				Object.keys(sqlite.constants),
-				[],
-				"constants should be empty in unenv stub"
-			);
-		}
-	},
 };
 
 /**