-
Notifications
You must be signed in to change notification settings - Fork 988
[main] destination-port/app-port should be configurable in map-route like with the new beta flag for destination-protocol/app-protocol #3613 #3612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
sorry wrong repo |
destination-port/app-port should be configurable in map-route like with the new beta flag for destination-protocol/app-protocol
|
meant to create this one first: funcf#1 with a slick description |
|
created #3613 for this. |
|
I had another look at the PR and worked on the integration tests. |
|
I have to touch the tests again as I oversaw the header rows... |
Description of the Change
This PR introduces support for setting the route destination port via the CF CLI
map-routecommand using a newapp-portparameter. This functionality is comparable to the existingapp-protocolparameter used for setting the destination protocol.The change enables users to specify the destination port directly when mapping a route to an application.
Why Is This PR Valuable?
This change improves the flexibility of the
map-routecommand by allowing users to configure the destination port for their routes directly from the CLI. This is particularly valuable for applications that require traffic to be routed to specific, non-default ports, aligning the CLI's capabilities with the underlying networking features.Especially this is useful for docker apps that have multiple ports, where the end user needs to switch tools to configure it via API oder Terraform instead of just using cf push from the command line as long as the CLI and the manifest do not support setting it.
Applicable Issues
How Urgent Is The Change?
This change is a feature enhancement and not time-sensitive.