Skip to content

Conversation

@robjuz
Copy link
Contributor

@robjuz robjuz commented Jul 24, 2020

fix #150

@cmfcmf
Copy link
Owner

cmfcmf commented Jul 30, 2020

Looks good, thank you! IIRC, the API up to some point always returned json errors, even when the requested format was XML. It seems like OWM fixed that. Regardless, using strpos instead of a verbatime JSON string is very reasonable. 👍

@cmfcmf cmfcmf changed the title Update OpenWeatherMap.php Fix 404 Not Found detection Jul 30, 2020
@cmfcmf cmfcmf merged commit bf32d21 into cmfcmf:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OWMNotFoundException never thrown

2 participants