ascii_video now builds ffmpeg and ncurses completely from CMake with ExternalProject

Author: cobyj33

.gitignore

@@ -7,15 +7,15 @@ blueprints/
 COMMITLOGGING.md
 devscripts/
 
-lib/ncurses-6.4/
-lib/ffmpeg-6.0/
 lib/aom
 lib/build
 install
 test*.sh
 
-lib/ffmpeg/build
-lib/ffmpeg/src
+lib/ffmpeg/build/
+lib/ffmpeg/src/
 
-lib/ncurses/build
-lib/ncurses/src
+lib/ncurses/build/
+lib/ncurses/src/
+
+ignore/

CMakeLists.txt

@@ -10,6 +10,9 @@ set(ASCII_VIDEO_VERSION_MINOR 4)
 set(ASCII_VIDEO_VERSION_PATCH 0)
 set(ASCII_VIDEO_VERSION "${ASCII_VIDEO_VERSION_MAJOR}.${ASCII_VIDEO_VERSION_MINOR}.${ASCII_VIDEO_VERSION_PATCH}")
 
+set(LOCAL_NCURSES_LIB ${CMAKE_SOURCE_DIR}/lib/ncurses)
+set(LOCAL_FFMPEG_LIB ${CMAKE_SOURCE_DIR}/lib/ffmpeg)
+
 set(ASCII_VIDEO_SUPPORTED_LANGUAGES CXX C)
 if (APPLE)
     list (APPEND ASCII_VIDEO_SUPPORTED_LANGUAGES OBJC OBJCXX)
@@ -31,36 +34,133 @@ LANGUAGES ${ASCII_VIDEO_SUPPORTED_LANGUAGES}
 DESCRIPTION "Terminal video media player")
 
 option(ASCII_VIDEO_BUILD_TESTS "Build Testing Executable for ascii_video" OFF)
-option(FALLBACK_BUILD_FROM_SHARED "Will build dependencies if the shared version is requested but is not found" ON)
-option(USE_SHARED_NCURSES "Use globally detected NCurses build" OFF)
-option(USE_SHARED_FFMPEG "Use globally detected FFmpeg" OFF)
-option(USE_SHARED_ALL "Use All Globally detected libraries" OFF)
-
-option(BUILD_FFMPEG_AS_SHARED "Build FFmpeg Library as a shared library. " OFF)
-option(BUILD_NCURSES_AS_SHARED "Build NCurses as a shared library." OFF)
 
 if (ASCII_VIDEO_BUILD_TESTS)
     message("Configured to build testing executable")
 else()
     message("Configured to NOT build testing executable")
 endif()
 
+set(NCURSES_CONFIGURE_OPTIONS --prefix=${CMAKE_BINARY_DIR}
+--datadir=${CMAKE_BINARY_DIR}/data
+--without-tests
+--without-manpages
+--without-progs
+--with-shared
+--without-normal
+--without-debug
+)
 
-if(NOT USE_SHARED_ALL)
-    add_subdirectory(${CMAKE_SOURCE_DIR}/lib)
-else()
-    find_package(Curses REQUIRED)
-    find_package(PkgConfig REQUIRED)
-    pkg_check_modules(
-        LIBAV REQUIRED IMPORTED_TARGET
-        libavformat
-        libavcodec
-        libswresample
-        libswscale
-        libavutil
-    )
+if (CMAKE_BUILD_TYPE STREQUAL "Debug")
+    list(APPEND NCURSES_CONFIGURE_OPTIONS --with-build-cflags=-g)
 endif()
 
+include(ExternalProject)
+ExternalProject_Add(
+    ncurses6
+    SOURCE_DIR        ${LOCAL_NCURSES_LIB}/src
+    BINARY_DIR        ${LOCAL_NCURSES_LIB}/build
+    PREFIX            ${CMAKE_BINARY_DIR}
+    INSTALL_DIR       ${CMAKE_BINARY_DIR}
+    CONFIGURE_COMMAND ${LOCAL_NCURSES_LIB}/src/configure ${NCURSES_CONFIGURE_OPTIONS}
+    BUILD_COMMAND     make
+    INSTALL_COMMAND   make install
+    BUILD_IN_SOURCE   OFF
+    URL               https://ftp.gnu.org/pub/gnu/ncurses/ncurses-6.4.tar.gz
+    TLS_VERIFY        ON
+)
+
+set(CURSES_LIBRARIES ${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}ncurses${CMAKE_SHARED_LIBRARY_SUFFIX}
+${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}form${CMAKE_SHARED_LIBRARY_SUFFIX})
+
+set(CURSES_INCLUDE_DIR ${CMAKE_BINARY_DIR}/include/ncurses)
+
+set(FFMPEG_BUILD_OPTIONS --prefix=${CMAKE_BINARY_DIR}
+--pkg-config-flags=--static
+--extra-cflags=-I${CMAKE_BINARY_DIR}/include
+--extra-ldflags=-L${CMAKE_BINARY_DIR}/lib
+--extra-libs=-lpthread
+--extra-libs=-lm
+--enable-rpath
+--enable-shared
+--disable-static
+--disable-network
+--disable-encoders
+--disable-muxers
+--disable-programs
+--disable-doc
+--disable-filters
+--disable-postproc
+--disable-avfilter
+--disable-avdevice
+--disable-protocols
+--disable-devices
+--enable-protocol=file,pipe)
+
+if (CMAKE_BUILD_TYPE STREQUAL "Debug")
+    list(APPEND FFMPEG_BUILD_OPTIONS --extra-cflags=-g)
+endif()
+# --enable-libdav1d
+# --enable-libvorbis
+# --ld="g++"
+# --disable-shared
+# --enable-static
+
+ExternalProject_Add(
+    ffmpeg
+    SOURCE_DIR              ${LOCAL_FFMPEG_LIB}/src
+    BINARY_DIR              ${LOCAL_FFMPEG_LIB}/build
+    GIT_REPOSITORY          https://git.ffmpeg.org/ffmpeg.git
+    GIT_SHALLOW             ON
+    UPDATE_DISCONNECTED     ON
+    STEP_TARGETS            update
+    CONFIGURE_COMMAND       ${LOCAL_FFMPEG_LIB}/src/configure ${FFMPEG_BUILD_OPTIONS}
+    PREFIX                  ${CMAKE_BINARY_DIR}
+    INSTALL_DIR             ${CMAKE_BINARY_DIR}
+    BUILD_COMMAND           make
+    BUILD_IN_SOURCE         OFF
+    INSTALL_COMMAND         make install
+)
+
+set(PKG_CONFIG_PATH_SEPARATOR :)
+if (WIN32)
+    set(PKG_CONFIG_PATH_SEPARATOR ;)
+endif()
+
+# set(ENV{PKG_CONFIG_PATH} ${CMAKE_BINARY_DIR}/lib/pkgconfig${PKG_CONFIG_PATH_SEPARATOR}$ENV{PKG_CONFIG_PATH})
+set(FFMPEG_LIBS ${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}avcodec${CMAKE_SHARED_LIBRARY_SUFFIX}
+${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}avformat${CMAKE_SHARED_LIBRARY_SUFFIX}
+${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}avutil${CMAKE_SHARED_LIBRARY_SUFFIX}
+${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}swresample${CMAKE_SHARED_LIBRARY_SUFFIX}
+${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}swscale${CMAKE_SHARED_LIBRARY_SUFFIX})
+set(FFMPEG_INCLUDE_DIR ${CMAKE_BINARY_DIR}/include)
+# set(ENV{PKG_CONFIG_PATH} ${CMAKE_BINARY_DIR}/lib/pkgconfig)
+# find_package(PkgConfig REQUIRED)
+# pkg_check_modules(
+#     LIBAV REQUIRED IMPORTED_TARGET
+#     libavformat
+#     libavcodec
+#     libswresample
+#     libswscale
+#     libavutil
+# )
+
+# if(NOT USE_SHARED_ALL)
+#     message("Experimental Library Building Enabled")
+#     # add_subdirectory(${CMAKE_SOURCE_DIR}/lib)
+# else()
+#     find_package(Curses REQUIRED)
+#     find_package(PkgConfig REQUIRED)
+#     pkg_check_modules(
+#         LIBAV REQUIRED IMPORTED_TARGET
+#         libavformat
+#         libavcodec
+#         libswresample
+#         libswscale
+#         libavutil
+#     )
+# endif()
+
 if(ASCII_VIDEO_BUILD_TESTS)
     add_subdirectory(./lib/Catch2)
 endif()
@@ -103,9 +203,12 @@ message("Curses Libraries found at " ${CURSES_LIBRARIES})
 
 add_executable(ascii_video ${COMMON_SOURCE_FILES} ./src/main.cpp)
 target_compile_features(ascii_video PRIVATE cxx_std_17)
-target_include_directories(ascii_video PRIVATE ${CURSES_INCLUDE_DIR} ./include ./lib/miniaudio ${CMAKE_CURRENT_BINARY_DIR}/include )
-target_link_libraries(ascii_video PRIVATE PkgConfig::LIBAV ${CURSES_LIBRARIES} $<TARGET_OBJECTS:miniaudio> argparse ${CMAKE_DL_LIBS})
-add_dependencies(ascii_video PkgConfig::LIBAV)
+target_include_directories(ascii_video PRIVATE ${FFMPEG_INCLUDE_DIR} ${CURSES_INCLUDE_DIR} ./include ./lib/miniaudio ${CMAKE_CURRENT_BINARY_DIR}/include )
+target_link_libraries(ascii_video PRIVATE ${FFMPEG_LIBS} ${CURSES_LIBRARIES} $<TARGET_OBJECTS:miniaudio> argparse ${CMAKE_DL_LIBS})
+add_dependencies(ascii_video ffmpeg ncurses6)
+set_target_properties(ascii_video PROPERTIES INSTALL_RPATH ${CMAKE_BINARY_DIR}/lib)
+set_target_properties(ascii_video PROPERTIES BUILD_WITH_INSTALL_RPATH ON)
+target_compile_options(ascii_video PRIVATE -Wl,-rpath,'$ORIGIN'/lib)
 
 if(MSVC)
     target_compile_options(ascii_video PRIVATE /std:c++17 /W4 /WX)
@@ -130,7 +233,10 @@ if (ASCII_VIDEO_BUILD_TESTS)
     else()
         target_compile_options(ascii_tests PRIVATE -Wall -Wextra -Wpedantic)# Consider adding -Werror back
     endif()
-    target_include_directories(ascii_tests PRIVATE ${CURSES_INCLUDE_DIR} ./include ./lib/miniaudio)
+    add_dependencies(tests ffmpeg ncurses6)
+    target_include_directories(ascii_tests PRIVATE ${FFMPEG_INCLUDE_DIR} ${CURSES_INCLUDE_DIR} ./include ./lib/miniaudio)
     target_compile_features(ascii_tests PRIVATE cxx_std_17)
-    target_link_libraries(ascii_tests PRIVATE Catch2::Catch2WithMain ${CURSES_LIBRARIES} PkgConfig::LIBAV $<TARGET_OBJECTS:miniaudio> ${CMAKE_DL_LIBS})
-endif()
+    target_link_libraries(ascii_tests PRIVATE Catch2::Catch2WithMain ${FFMPEG_LIBS} ${CURSES_LIBRARIES} PkgConfig::LIBAV $<TARGET_OBJECTS:miniaudio> ${CMAKE_DL_LIBS})
+    set_target_properties(ascii_tests PROPERTIES INSTALL_RPATH ${CMAKE_BINARY_DIR}/lib)
+    set_target_properties(ascii_tests PROPERTIES BUILD_WITH_INSTALL_RPATH ON)
+endif()

lib/CMakeLists.txt

@@ -28,7 +28,7 @@ AVFormatContext* open_format_context(std::string file_path) {
         if (format_context != nullptr) {
             avformat_free_context(format_context);
         }
-        throw std::runtime_error("Failed to find stream info for " + file_path);
+        throw ascii::ffmpeg_error("Failed to find stream info for " + file_path, result);
     }
 
     if (format_context != nullptr) {