From 9332bdd34c11f2347f12387cb7d466b2680f878a Mon Sep 17 00:00:00 2001 From: Ihsan Ullah Date: Sun, 5 Nov 2023 19:35:03 +0500 Subject: [PATCH 1/2] show docker pull or execution time limit error in scoring_std_err when these occur during scoring --- compute_worker/compute_worker.py | 1 + src/apps/api/views/submissions.py | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/compute_worker/compute_worker.py b/compute_worker/compute_worker.py index f9b74d27b..f42b1b6dc 100644 --- a/compute_worker/compute_worker.py +++ b/compute_worker/compute_worker.py @@ -376,6 +376,7 @@ def _get_container_image(self, image_name): docker_pull_fail_data = { "type": "Docker_Image_Pull_Fail", "error_message": error_message, + "is_scoring": self.is_scoring } # Send data to be written to ingestion logs self._update_submission(docker_pull_fail_data) diff --git a/src/apps/api/views/submissions.py b/src/apps/api/views/submissions.py index 6ce9da84b..ac026baa1 100644 --- a/src/apps/api/views/submissions.py +++ b/src/apps/api/views/submissions.py @@ -68,9 +68,8 @@ def check_object_permissions(self, request, obj): # Set file name to ingestion std error as default error_file_name = "prediction_ingestion_stderr" - # Change error file name when error comes from execution time limit - # and error occured during scoring - if request.data["type"] == "Execution_Time_Limit_Exceeded" and request.data['is_scoring'] == "True": + # Change error file name to scoring_stderr when error occurs during scoring + if request.data['is_scoring'] == "True": error_file_name = "scoring_stderr" try: From 1bc1fec66f9982bb6151a5404581ec00ddfc72b9 Mon Sep 17 00:00:00 2001 From: Ihsan Ullah Date: Thu, 18 Jan 2024 20:33:24 +0500 Subject: [PATCH 2/2] Update submissions.py --- src/apps/api/views/submissions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/api/views/submissions.py b/src/apps/api/views/submissions.py index ac026baa1..b61963f9b 100644 --- a/src/apps/api/views/submissions.py +++ b/src/apps/api/views/submissions.py @@ -69,7 +69,7 @@ def check_object_permissions(self, request, obj): error_file_name = "prediction_ingestion_stderr" # Change error file name to scoring_stderr when error occurs during scoring - if request.data['is_scoring'] == "True": + if request.data.get("is_scoring", "False") == "True": error_file_name = "scoring_stderr" try: