Convert to TypeScript#308
Conversation
stephenliang
left a comment
There was a problem hiding this comment.
Very minor nits, all of which are probably considered stylistic or out of scope for this PR (error handling scenarios). However I do think we can possibly avoid a type cast in the dispatcher.
|
I have rebased, added a |
3dd08be to
5303ee1
Compare
|
Added prettier config to match the main repo and just had it 'fix' everything. Now it should conform 99% to what the frontend packages directory wants. |
The empty string is so that the function is always typed to a string since everything downstream just expects it to be a string anyway. This is still falsey and I don't think it can ever be undefined anyway.
|
I confirmed that all of the modes work, the metrics fire, and the animations seem to be correct. No major issues, certainly. |
Uses the strict TypeScript config in
/frontend/packages/lint-configto get this repo locked to the same TypeScript and TS linting situation as the main repo.This also converts
function MyComponent({}) { }intoconst MyComponent = ({}: MyComponentProps) => { }Snuck an upgrade to fontawesome which just updated the package.json/yarn.lock.
2026-04-09.14-54-52.mp4