Fix retryFailedStep ignoredSteps exact-name matching (#5571)

* Fix retryFailedStep ignoredSteps exact-name matching

The wildcard check used `ignored.indexOf('*')` as a boolean. `-1` is
truthy in JavaScript (only `0` is falsy), so entries without `*` were
matched via `startsWith(slice(0, -1))` instead of exact compare, which
also chops the last character — broadening the match further.

`ignoredSteps: ['see']` silently ignored `seeElement`, `seeInField`,
`selectOption`, `sendPostRequest` — anything starting with `se`.

Compare against `-1` explicitly so exact-name entries only match
themselves, as the docs describe.

* fix(retryFailedStep): avoid mutating shared defaultConfig

Each call to retryFailedStep mutated the module-level defaultConfig via
Object.assign(defaultConfig, config), so config.when from a prior call leaked
into the next as customWhen and chained recursively. In tests this made
when() return undefined for closures that no longer had a live step.started
listener (e.g. after event.cleanDispatcher), causing the new regression test
to fail in the full unit suite even though it passed in isolation.

Use Object.assign({}, defaultConfig, config) so each registration gets an
independent config object. Rewrites the regression test to assert via
retryConfig.when() directly, which is now sound.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Michael Bodnarchuk <davert.ua@gmail.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: 3 people

lib/plugin/retryFailedStep.js

@@ -116,7 +116,7 @@ export default function (config) {
       if (step.title === ignored) return
       if (ignored instanceof RegExp) {
         if (step.title.match(ignored)) return
-      } else if (ignored.indexOf('*') && step.title.startsWith(ignored.slice(0, -1))) return
+      } else if (ignored.indexOf('*') !== -1 && step.title.startsWith(ignored.slice(0, -1))) return
     }
     enableRetry = true
   })

test/unit/plugin/retryFailedStep_test.js

@@ -186,6 +186,23 @@ describe('retryFailedStep', () => {
     // expects to retry only once
   })
 
+  it('should not treat exact-name ignoredSteps entries as wildcard prefixes', () => {
+    // Regression: ignored.indexOf('*') was used as truthy check.
+    // -1 is truthy, so entries without '*' were matched via startsWith(slice(0, -1)).
+    // ignoredSteps: ['see'] would silently ignore seeElement, seeInField, selectOption, etc.
+    retryFailedStep({ retries: 2, minTimeout: 1, ignoredSteps: ['see'] })
+    store.autoRetries = true
+    const retryConfig = recorder.retries[recorder.retries.length - 1]
+
+    event.dispatcher.emit(event.step.started, { title: 'seeElement' })
+    expect(retryConfig.when(new Error()), "'seeElement' must not be ignored when only 'see' is configured").to.equal(true)
+
+    event.dispatcher.emit(event.step.passed, {})
+
+    event.dispatcher.emit(event.step.started, { title: 'see' })
+    expect(retryConfig.when(new Error()), "exact match 'see' must still be ignored").to.not.equal(true)
+  })
+
   it('should add custom regexp steps to ignore', async () => {
     retryFailedStep({ retries: 2, minTimeout: 1, ignoredSteps: [/somethingNew/] })
     event.dispatcher.emit(event.test.before, createTest('test'))