auth login process fixed - new controller authindex

* the variables will be username and userclave, except in the DB table
* changed all the links and references from `Login` to `IndexLogin/auth`
* changed the menu logout reference to `Indexlogin/auth/logout`
* changed the login referende in the Index point entry
* remove the redundant detection of profiler debug view/class in controlles
  its already inherit from the core controller `CP_Controller`
* implements `sessionficha` (creation by) and `sessionflag` (modified by)
  in the core controller as class variables (from DB/session)
* improve the `datasession()` function with a writing flag detection
  in the core controller to determine if the user can manage rates
* add the `$this->checksession();` in all controllers, but this will
  not logout the user, is just to check if user can write to the currency
  database and can change the rate currency values.
* remove the `gemenu()` cos here we used the hardcoded menu from
  @radioactive99 so now he must manage a way to explain the menu footer
* closes #14 from https://gitlab.com/codeigniterpower/codeigniter-currencylib/-/issues/14

Author: mckaygerhard

cweb/elcurrencyweb/controllers/Currency_Api.php

@@ -17,7 +17,7 @@ function __construct()
 	{
 		parent::__construct();
 		$this->load->helper(array('form', 'url','html'));
-		$this->output->enable_profiler(ENVIRONMENT !== 'production');
+		$this->output->enable_profiler(FALSE); // set to true only to debug the json results api
 	}
 
 

cweb/elcurrencyweb/controllers/Currency_Converter.php

@@ -19,7 +19,7 @@ function __construct()
 	{
 		parent::__construct();
 		$this->load->helper(array('form', 'url','html'));
-		$this->output->enable_profiler(ENVIRONMENT !== 'production');
+		$this->checksession();
 
 	}
 

cweb/elcurrencyweb/controllers/Currency_History.php

@@ -16,8 +16,8 @@ class Currency_History extends CP_Controller {
 	function __construct()
 	{
 		parent::__construct();
-	$this->load->helper(array('form', 'url','html'));
-	$this->output->enable_profiler(ENVIRONMENT !== 'production');
+		$this->load->helper(array('form', 'url','html'));
+		$this->checksession();
 
 	}
 

cweb/elcurrencyweb/controllers/Currency_Manager.php

@@ -17,7 +17,7 @@ function __construct()
 	{
 		parent::__construct();
 		$this->load->helper(array('form', 'url','html'));
-		$this->output->enable_profiler(ENVIRONMENT !== 'production');
+		$this->checksession();
 	}
 
 	/**

cweb/elcurrencyweb/controllers/Currency_Users.php

@@ -18,7 +18,7 @@ function __construct()
 	{
 		parent::__construct();
 		$this->load->helper(array('form', 'url','html'));
-		$this->output->enable_profiler(ENVIRONMENT !== 'production');
+		$this->checksession();
 	}
 
 	/**

cweb/elcurrencyweb/controllers/Home.php

@@ -19,8 +19,7 @@ function __construct()
 	{
 		parent::__construct();
 		$this->load->helper(array('form', 'url','html'));
-		$this->output->enable_profiler(ENVIRONMENT !== 'production');
-
+		$this->checksession();
 	}
 
 	/**
@@ -33,7 +32,6 @@ function __construct()
 	public function index()
 	{
 		$data = array();
-		$data['menu'] = $this->genmenu();
 		$data['currentctr'] = $this->currentctr;
 		$data['currentinx'] = $this->currentinx;
 		$data['currenturl'] = $this->currenturl;

cweb/elcurrencyweb/controllers/Indexauth.php

@@ -1,57 +1,51 @@
 <?php if ( ! defined('BASEPATH')) exit('No direct script access allowed');
 
-
-class Indexauth extends YA_Controller {
+class Indexauth extends CP_Controller {
 
 	function __construct()
 	{
 		parent::__construct();
-		$data['menu'] = $this->genmenu();
-		$data['menusub'] = '';
-		$this->data = $data;
 	}
 
-	/**
-	 * index que muestra login para autenticacion, y verifica esta contra el modelo de datos
-	 * este controlador no necesita verirficar la session ya que este solo muestra si entra o no
-	 * 
-	 * @name: index
-	 * @param void
-	 * @return void
-	 */
-	public function index($data = NULL)
+	public function index($indexerror = NULL)
 	{
+		$data = array();
 		$message = 'Auth system prepared';
-
-		if(is_array($data))
-		{
-		    array_merge($this->data,$data);
-		}
-		else
+		if( !is_array($indexerror) AND $indexerror != NULL)
 		{
-		    if($data == 'autherror')
+		    if($indexerror == 'autherror')
 			    $message = 'Error login or invalid credentials';
-		    if($data == 'authcheck')
+		    if($indexerror == 'authcheck')
 			    $message = 'Invalid access or invalid credentials';
-		    if($data == 'logout')
+		    if($indexerror == 'logout')
 			    $message = 'Session closed';
-		    if($data == 'logauth')
-			    $message = 'Auth prepared to valid credentials';
-		    $data = $this->data;
+		    if($indexerror == 'logauth')
+			    $message = 'Ready again to valid credentials';
 		}
-
-		$this->config->load('imap');
-		$data['sitename'] = $this->config->item('imap_host');
-
 		$data['message'] = $message;
+		$data['currentctr'] = $this->currentctr;
+		$data['currentinx'] = $this->currentinx;
+		$data['currenturl'] = $this->currenturl;
+		$data['controllerlogin'] = 'Indexauth/auth/login';
+		$data['userurl'] = $this->input->get_post('userurl');
 		$this->load->view('header.php',$data);
-		$this->load->view('inicion.php',$data);
+		$this->load->view('login.php',$data);
 		$this->load->view('footer.php',$data);
 	}
 
+	/**
+	 * authenticator that uses action and user key credentials
+	 * 
+	 * @name: auth
+	 * @param string $action logout|login
+	 * @param string $username the user email or login name
+	 * @param string $userclave the user password or user key api access
+	 * @return
+	 * 
+	 */
 	public function auth($action = 'logout', $username = NULL, $userclave = NULL)
 	{
-		$typeerror = 'logout';
+		$typeerror = 'nologin';
 
 		if($username == NULL)
 			$username = $this->input->post('username');
@@ -63,29 +57,33 @@ public function auth($action = 'logout', $username = NULL, $userclave = NULL)
 			$this->load->model('authmodel');
 			$im_access = $this->authmodel->authimap($username, $userclave);
 			$rs_access = $this->authmodel->authtable($username, $userclave);
+
 			if($im_access == FALSE)
 				$typeerror = 'autherror';
 			if($rs_access == FALSE)
 				$typeerror = 'authcheck';
 		}
 
-		if ( $action == 'logauth' )
-			$typeerror = 'logauth';
+		if ( $action == 'logauth' OR $action == 'logout' )
+			$typeerror = $action;
 
 		$data = array();
-		if($rs_access AND $im_access)
+		if($rs_access != FALSE AND $im_access != FALSE)
 		{
 			$this->session->set_userdata('userdata', $rs_access);
-			redirect('Index/vistainterna');
+			redirect('Home');
 		}
 		else
 		{
-			$this->session->sess_destroy(); sleep(3);
-			header('location:'.site_url('/Indexauth/index/'.$typeerror));
+			$this->session->sess_destroy();
+			if($action == 'logout')
+				redirect('Index');
+			else
+				header('location:'.site_url('/Indexauth/index/'.$typeerror));
 		}
 	}
 
 }
 
-/* End of file Indexauth.php */
-/* Location: ./application/controllers/Indexauth.php */
+/* End of file welcome.php */
+/* Location: ./application/controllers/welcome.php */