From ec09be375eeaca8547737fa2c7e2b8b2b885ae69 Mon Sep 17 00:00:00 2001 From: Kacper Sawicki Date: Mon, 2 Feb 2026 12:33:30 +0000 Subject: [PATCH] fix(ci): use valid action versions in release.yaml - actions/checkout@v6 doesn't exist, use pinned v4 SHA - actions/setup-go@v6 doesn't exist, use pinned v5 SHA - Update go-version from 1.22 to 1.24 for consistency with ci.yaml - Fix test goroutine leak: close yamux session when context done --- .github/workflows/release.yaml | 6 +++--- logger_test.go | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index d214843..c1692ce 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -20,12 +20,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v6 + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 - name: Setup Go - uses: actions/setup-go@v6 + uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5 with: - go-version: "~1.22" + go-version: "~1.24" - name: Get Version run: echo "version=$(./scripts/version.sh)" >> $GITHUB_OUTPUT diff --git a/logger_test.go b/logger_test.go index 163fd15..fd1dbcf 100644 --- a/logger_test.go +++ b/logger_test.go @@ -1228,7 +1228,13 @@ func newFakeAgentAPI(t *testing.T) *fakeAgentAPI { Message: "Failed to accept websocket.", Detail: err.Error(), }) + return } + // Ensure session is closed when context is done to unblock Serve + go func() { + <-ctx.Done() + _ = session.Close() + }() err = dserver.Serve(ctx, session) logger.Info(ctx, "drpc serveone", slog.Error(err))