[ANSIENG-5798] | Revert pipefail changes (#2420)

Author: rkunwar-28

docs/VARIABLES.md

@@ -54,7 +54,7 @@ Default:  true
 
 ### shell_executable
 
-Path to bash executable for shell tasks that require pipefail. Override if bash is at a different location on your systems.
+Path to bash executable for shell tasks. Override if bash is at a different location on your systems.
 
 Default:  /bin/bash
 

roles/common/tasks/cert_principal_extract.yml

@@ -8,7 +8,6 @@
   # we dont need to handle fips seperately as in fips bouncy castle is used but normal jks keystore is also present.
   # In case we try to fetch from bouncy castle keystore we need to handle each component differently as it is only present on kafka others dont have it
   shell: |
-    set -o pipefail
     keytool -list -keystore {{keystore_path}} \
         -storepass {{keystore_storepass}} \
         {% if fips_enabled|bool and ('kafka_controller' in group_names or 'kafka_broker' in group_names) %}

roles/common/tasks/config_validations.yml

@@ -1,7 +1,7 @@
 ---
 - name: Retrieve SSL public key hash from private key on Local Host
   shell:
-    cmd: set -o pipefail; openssl pkey -pubout | openssl sha256
+    cmd: openssl pkey -pubout | openssl sha256
     stdin: "{{ lookup('file', ssl_key_filepath) }}"
     executable: "{{ shell_executable }}"
   register: key_hash_local
@@ -29,7 +29,7 @@
 
 - name: Retrieve SSL public key Hash from private key on Remote Host
   shell:
-    cmd: set -o pipefail; openssl pkey -pubout | openssl sha256
+    cmd: openssl pkey -pubout | openssl sha256
     stdin: "{{ remote_key['results'][group_idx].content | b64decode }}"
     executable: "{{ shell_executable }}"
   register: key_hash_remote
@@ -46,7 +46,7 @@
 
 - name: Retrieve SSL public key hash from X509 certificate on Local Host
   shell:
-    cmd: set -o pipefail; openssl x509 -noout -pubkey | openssl sha256
+    cmd: openssl x509 -noout -pubkey | openssl sha256
     stdin: "{{ lookup('file', ssl_signed_cert_filepath) }}"
     executable: "{{ shell_executable }}"
   register: cert_hash_local
@@ -74,7 +74,7 @@
 
 - name: Retrieve SSL public key hash from X509 certificate on Remote Host
   shell:
-    cmd: set -o pipefail; openssl x509 -noout -pubkey | openssl sha256
+    cmd: openssl x509 -noout -pubkey | openssl sha256
     stdin: "{{ remote_cert['results'][group_idx].content | b64decode }}"
     executable: "{{ shell_executable }}"
   register: cert_hash_remote
@@ -339,4 +339,4 @@
     that:
       - not (control_center_next_gen_dependency_alertmanager_ssl_enabled | bool and control_center_next_gen_dependency_alertmanager_mtls_enabled | bool and control_center_next_gen_dependency_alertmanager_basic_auth_enabled | bool)
     fail_msg: "Alertmanager SSL, mTLS, and Basic Auth cannot all be enabled simultaneously."
-  tags: validate
+  tags: validate

roles/common/tasks/masterkey.yml

@@ -8,7 +8,6 @@
 - name: Generate Master Encryption Key and File
   tags: masterkey
   shell: |
-    set -o pipefail
     {{ confluent_cli_path }} secret master-key generate \
       --local-secrets-file /tmp/security.properties \
       --passphrase @/tmp/passphrase.txt | awk '/Master/{print $5}'

roles/common/tasks/rbac_setup.yml

@@ -43,7 +43,6 @@
 
 - name: Get Kafka Cluster ID from Zookeeper
   shell: >
-      set -o pipefail;
       {{ binary_base_path }}/bin/zookeeper-shell {{ groups['zookeeper'][0] }}:{{zookeeper_client_port}} \
       {% if zookeeper_ssl_enabled|bool %}-zk-tls-config-file {{ kafka_broker.zookeeper_tls_client_config_file \
       if kafka_broker_secrets_protection_enabled else kafka_broker.config_file }}{% endif %} \

roles/common/tasks/update_log4j.yml

@@ -31,7 +31,6 @@
 
 - name: Register Appenders
   shell: |
-    set -o pipefail
     grep RollingFileAppender {{log4j_file}} | cut -d '=' -f 1 | cut -d '.' -f 3
   args:
     executable: /bin/bash

roles/control_center_next_gen/tasks/health_check.yml

@@ -145,7 +145,7 @@
     - validation
 
 - name: Validate Cron Jobs for Logrotate
-  shell: set -o pipefail && crontab -l | grep -c "{{ item }}"
+  shell: crontab -l | grep -c "{{ item }}"
   args:
     executable: "{{ shell_executable }}"
   register: logrotate_cron_validation

roles/kafka_broker/tasks/set_principal.yml

@@ -26,7 +26,6 @@
   # Extract DNAME from line
   # Remove spaces after commas
   shell: |
-    set -o pipefail
     keytool -list -keystore {{kb_keystore_path}} \
         -storepass {{kb_keystore_storepass}} \
         {% if fips_enabled|bool %}

roles/kafka_controller/tasks/health_check.yml

@@ -39,7 +39,6 @@
 #Registers LEO of controllers only if Metadata Quorum passed in the above task
 - name: Register LogEndOffset
   shell: |
-    set -o pipefail
     {{ binary_base_path }}/bin/kafka-metadata-quorum --bootstrap-{{bootstrap_server_or_controller}} {{server_hostname}}:{{server_port}} \
       --command-config {{kafka_controller.client_config_file}} describe --replication |  grep -v Observer | awk '{print $3}'
   args:

roles/kafka_controller/tasks/set_principal.yml

@@ -26,7 +26,6 @@
   # Extract DNAME from line
   # Remove spaces after commas
   shell: |
-    set -o pipefail
     keytool -list -keystore {{kc_keystore_path}} \
         -storepass {{kc_keystore_storepass}} \
         {% if fips_enabled|bool %}