Refresh quality control state only when necessary (#901)

* add modification counters

refresh only once a mod count that matters changes.

* Remove selected attribute change avoidance

Author: aldebaran30701

CoreQualityControlView/src/au/gov/asd/tac/constellation/views/qualitycontrol/daemon/QualityControlAutoVetter.java

@@ -27,7 +27,9 @@
 import au.gov.asd.tac.constellation.graph.schema.visual.concept.VisualConcept;
 import au.gov.asd.tac.constellation.plugins.PluginException;
 import au.gov.asd.tac.constellation.plugins.PluginExecution;
+import au.gov.asd.tac.constellation.plugins.PluginInfo;
 import au.gov.asd.tac.constellation.plugins.PluginInteraction;
+import au.gov.asd.tac.constellation.plugins.PluginType;
 import au.gov.asd.tac.constellation.plugins.parameters.PluginParameters;
 import au.gov.asd.tac.constellation.plugins.templates.SimpleReadPlugin;
 import au.gov.asd.tac.constellation.views.qualitycontrol.QualityControlEvent;
@@ -51,13 +53,13 @@
 public final class QualityControlAutoVetter implements GraphManagerListener, GraphChangeListener {
 
     private static QualityControlAutoVetter INSTANCE = null;
-
     private static final List<QualityControlAutoVetterListener> buttonListeners = new ArrayList<>();
 
     private QualityControlState state;
 
     private Graph currentGraph;
     private long lastGlobalModificationCounter;
+    private long lastCameraModificationCounter;
 
     private final List<QualityControlListener> listeners;
 
@@ -152,10 +154,17 @@ public void graphChanged(final GraphChangeEvent event) {
         if (graph != null) {
             final ReadableGraph readableGraph = graph.getReadableGraph();
             try {
+                final int cameraAttribute = VisualConcept.GraphAttribute.CAMERA.get(readableGraph);
+
                 final long thisGlobalModificationCounter = readableGraph.getGlobalModificationCounter();
+                final long thisCameraModificationCounter = readableGraph.getValueModificationCounter(cameraAttribute);
+
                 if (thisGlobalModificationCounter != lastGlobalModificationCounter) {
-                    updateQualityControlState(graph);
+                    if (lastCameraModificationCounter == thisCameraModificationCounter) {
+                        updateQualityControlState(graph);
+                    }
                     lastGlobalModificationCounter = thisGlobalModificationCounter;
+                    lastCameraModificationCounter = thisCameraModificationCounter;
                 }
             } finally {
                 readableGraph.release();
@@ -288,6 +297,7 @@ public static synchronized QualityControlAutoVetter getInstance() {
         return INSTANCE;
     }
 
+    @PluginInfo(pluginType = PluginType.UPDATE, tags = {"LOW LEVEL"})
     private static class QualityControlViewStateUpdater extends SimpleReadPlugin {
 
         @Override
@@ -352,7 +362,7 @@ public void read(final GraphReadMethods graph, final PluginInteraction interacti
 
         @Override
         public String getName() {
-            return "Quality Control View: Save State";
+            return "Quality Control View: Update State";
         }
     }