Bump golangci-lint to 1.45.2

1. Greatly simplify the golangci-lint config.

1.1. Remove the skip-dir list (of excluded directories), since as all
     the issues are now fixed).

1.2. Instead of enabling all the linters and then disabling many of
     them, go with the default set of enabled linters, and then add some
     (currently just gocritic and dupl).

     This will hopefully make upgrading golangci-lint easier, as it
     maintains a sensitive set of linters enabled by default (and
     enabling all linters by default means we will enable some new and
     unknown linters when we bump golangci-lint version).

1.3. Remove the gocritic list of enabled linters, use a default one.
     The motivation is similar -- it is hard to maintain/upgrade otherwise.

1.4. Remove the "check-blank: true" option from the errcheck linter, as
     we often use _ = fn() type of assignment to denote that we want to
     ignore the error.

2. Simplify golangci-lint installation from the Makefile.

3. Bump golangci-lint to 1.45.2.

NOTE that if you are using golangci-lint locally, you have to remove it
from the build directory (i.e. rm -f build/golangci-lint) before running
"make validate").

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

Author: kolyshkin

.golangci.yml

@@ -1,9 +1,5 @@
 ---
 run:
-  skip-dirs:
-    - libimage/manifests
-    - pkg/manifests
-    - pkg/supplemented
   build-tags:
     - apparmor
     - seccomp
@@ -13,107 +9,12 @@ run:
   concurrency: 6
   deadline: 5m
 linters:
-  enable-all: true
-  disable:
-    - asciicheck
-    - errcheck
-    - exhaustive
-    - funlen
-    - gochecknoglobals
-    - gochecknoinits
-    - gocognit
-    - goconst
-    - godot
-    - godox
-    - goerr113
-    - gofumpt
-    - golint
-    - gomnd
-    - gosec
-    - lll
-    - maligned
-    - nestif
-    - nlreturn
-    - prealloc
-    - stylecheck
-    - testpackage
-    - unconvert
-    - whitespace
-    - wsl
+  enable:
+    - dupl
+    - gocritic
 linters-settings:
   errcheck:
     check-type-assertions: true
-    check-blank: true
-  gocritic:
-    enabled-checks:
-      # Diagnostic
-      - appendAssign
-      - argOrder
-      - badCond
-      - caseOrder
-      - codegenComment
-      - commentedOutCode
-      - deprecatedComment
-      - dupArg
-      - dupBranchBody
-      - dupCase
-      - dupSubExpr
-      - exitAfterDefer
-      - flagDeref
-      - flagName
-      - nilValReturn
-      - offBy1
-      - sloppyReassign
-      - weakCond
-      - octalLiteral
-
-      # Performance
-      - appendCombine
-      - equalFold
-      - hugeParam
-      - indexAlloc
-      - rangeExprCopy
-      - rangeValCopy
-
-      # Style
-      - assignOp
-      - boolExprSimplify
-      - captLocal
-      - commentFormatting
-      - commentedOutImport
-      - defaultCaseOrder
-      - docStub
-      - elseif
-      - emptyFallthrough
-      - emptyStringTest
-      - hexLiteral
-      - ifElseChain
-      - methodExprCall
-      - regexpMust
-      - singleCaseSwitch
-      - sloppyLen
-      - stringXbytes
-      - switchTrue
-      - typeAssertChain
-      - typeSwitchVar
-      - underef
-      - unlabelStmt
-      - unlambda
-      - unslice
-      - valSwap
-      - wrapperFunc
-      - yodaStyleExpr
-
-      # Opinionated
-      - builtinShadow
-      - importShadow
-      - initClause
-      - nestingReduce
-      - paramTypeCombine
-      - ptrToRefParam
-      - typeUnparen
-      - unnamedResult
-      - unnecessaryBlock
   gocyclo:
     min-complexity: 35
 

Makefile

@@ -67,13 +67,9 @@ vendor:
 .PHONY: install.tools
 install.tools: build/golangci-lint .install.md2man
 
+build/golangci-lint: VERSION=v1.45.2
 build/golangci-lint:
-	export \
-		VERSION=v1.30.0 \
-		URL=https://raw.githubusercontent.com/golangci/golangci-lint \
-		BINDIR=build && \
-	curl -sfL $$URL/$$VERSION/install.sh | sh -s $$VERSION
-
+	curl -fsSL https://raw.githubusercontent.com/golangci/golangci-lint/$(VERSION)/install.sh | sh -s -- -b ./build $(VERSION)
 
 .install.md2man:
 	$(GO) install github.com/cpuguy83/go-md2man/v2@latest