specgen: skip /dev/mqueue mount if not available#28639
Merged
Luap99 merged 1 commit intoMay 5, 2026
Merged
Conversation
giuseppe
added
the
No New Tests
Contributor
|
lgtm |
Luap99
reviewed
May 4, 2026
check /proc/filesystems to determine if the kernel supports the mqueue filesystem. If it doesn't, skip the /dev/mqueue mount in the container. This can happen with the libkrunfw kernel that does not have support for mqueue. Closes: containers/crun#2080 Closes: containers/libkrun#653 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
skip-dev-mqueue-if-not-present
branch
from
c58a8cd to
1bda61b
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Luap99
approved these changes
May 5, 2026
|
|
||
| const devMqueue = "/dev/mqueue" | ||
|
|
||
| func isMqueueSupported() bool { |
Contributor
There was a problem hiding this comment.
not blocking, I suppose for podman system service it might make sense to put this into a sync.OnceValue function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not add/dev/mqueue to the container if the device is not present on the host. This can happen if the kernel doesn't have support for mqueue, as it is the case with the libkrunfw kernel.
Closes: containers/crun#2080
Closes: containers/libkrun#653
I've not added any new tests as it requires a system where /dev/mqueue is not present.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?