Fix bug where querier may not be able to achieve max-concurrent#4417
Merged
pstibrany merged 5 commits intoAug 17, 2021
Merged
Conversation
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
jeromeinsf
approved these changes
Aug 11, 2021
bboreham
approved these changes
Aug 11, 2021
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Good catch! I suggested different wording for the changelog: we want this text to be meaningful to Cortex admins without needing to read the bug report.
aknuds1
suggested changes
Aug 11, 2021
Co-authored-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
force-pushed
the
issue-4391-achieve-max-concurrent
branch
from
88f05d7 to
2fbbe42
Compare
alanprot
approved these changes
Aug 16, 2021
alvinlin123
added a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…exproject#4417) * Fix bug where querier may not be able to achieve max-concurrent Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update change log Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update CHANGELOG.md Co-authored-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update pkg/querier/worker/worker_test.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Address PR comments Signed-off-by: Alvin Lin <alvinlin@amazon.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alvin Lin alvinlin@amazon.com
What this PR does:
This PR fixes #4391
Which issue(s) this PR fixes:
Fixes #4391
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]