Update Thanos to v0.19.1-0.20210923155558-c15594a03c45.#4505
Merged
Conversation
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pracucci
approved these changes
Oct 1, 2021
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
…using lint check. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
bboreham
reviewed
Oct 1, 2021
| // TODO review the change introduced by https://github.com/grpc/grpc-go/pull/4416 before upgrading to 1.39.0 | ||
| replace google.golang.org/grpc => google.golang.org/grpc v1.38.0 | ||
|
|
||
| replace github.com/thanos-io/thanos v0.22.0 => github.com/thanos-io/thanos v0.19.1-0.20210923155558-c15594a03c45 |
Contributor
There was a problem hiding this comment.
Please, whenever you pin a version, add a comment stating why, and under what conditions we will remove the pin.
Contributor
Author
There was a problem hiding this comment.
Pin is used to make sure we use version from master. Otherwise go modules want to use v0.22, which is latest tag (update: now it’s actually v0.23, which is more recent), but is not reachable from master, so we would be stuck with version from July.
Contributor
There was a problem hiding this comment.
Yeah put it in the file so I can see it and not have to trace back through PRs.
Contributor
|
Here are the changes I identified in Thanos code:
I think the first one would deserve a mention in the changelog, if it works for users. |
bboreham
added a commit
that referenced
this pull request
Oct 1, 2021
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
3 tasks
bboreham
added a commit
that referenced
this pull request
Oct 1, 2021
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
…t#4505) * Update Thanos to v0.19.1-0.20210923155558-c15594a03c45. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added forgotten vendored files Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use original version of file with CRLF line separators, to avoid confusing lint check. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
…texproject#4507) * Add 1.11.0-rc.0 marker to CHANGELOG * Add changelog entries for cortexproject#4505 Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…t#4505) * Update Thanos to v0.19.1-0.20210923155558-c15594a03c45. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added forgotten vendored files Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use original version of file with CRLF line separators, to avoid confusing lint check. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…texproject#4507) * Add 1.11.0-rc.0 marker to CHANGELOG * Add changelog entries for cortexproject#4505 Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
This was referenced Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR updates Thanos to v0.19.1-0.20210923155558-c15594a03c45.
This PR does not integrate new Thanos' compactor feature for skipping blocks with out of order chunks.
This PR also updates Prometheus, but doesn't integrate new snapshot on shutdown feature yet.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]