Update go-kit/kit to 0.12.0 to fix spurious debug logs#4544
Merged
Conversation
This version of go-kit/kit/log is just a pass-through to go-kit/log. Also updates the following: * github.com/aws/aws-sdk-go from v1.40.37 to v1.40.45 * github.com/go-kit/log from v0.1.0 to v0.2.0 * github.com/json-iterator/go from v1.1.11 to v1.1.12 * golang.org/x/net from ad29c8ab022f to 978cfadd31cf Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Reduce the amount of noise until after Cortex v1.11 is released. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
force-pushed
the
update-go-kit
branch
from
73467f0 to
ec4a675
Compare
Apparently updating go-kit has made our log lines more consistent Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
pracucci
approved these changes
Nov 4, 2021
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
…#4544) * Update go-kit/kit to 0.12.0 to fix spurious debug logs This version of go-kit/kit/log is just a pass-through to go-kit/log. (Note pinned aws-sdk to previous version) Also updates the following: * github.com/go-kit/log from v0.1.0 to v0.2.0 * github.com/json-iterator/go from v1.1.11 to v1.1.12 * golang.org/x/net from ad29c8ab022f to 978cfadd31cf Also: * compactor unit tests: make log messages consistent Apparently updating go-kit has made our log lines more consistent Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…#4544) * Update go-kit/kit to 0.12.0 to fix spurious debug logs This version of go-kit/kit/log is just a pass-through to go-kit/log. (Note pinned aws-sdk to previous version) Also updates the following: * github.com/go-kit/log from v0.1.0 to v0.2.0 * github.com/json-iterator/go from v1.1.11 to v1.1.12 * golang.org/x/net from ad29c8ab022f to 978cfadd31cf Also: * compactor unit tests: make log messages consistent Apparently updating go-kit has made our log lines more consistent Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version of go-kit/kit/log is just a pass-through to go-kit/log.
Also updates the following:
I have read through most of the code changes, and don't see anything material to Cortex.
Nearly all of the bulk is changes to comments.
Checklist
CHANGELOG.mdupdatedSince the move to go-kit/log in #4421 was not put in CHANGELOG, I don't think this change needs one either.