From fd780eaeb0e075c0a7ab8d4dda429823ceea2a56 Mon Sep 17 00:00:00 2001 From: Anand Rajagopal Date: Tue, 3 Jun 2025 18:28:29 +0000 Subject: [PATCH 1/2] Prevent counting 2xx responses as failed writes Signed-off-by: Anand Rajagopal --- pkg/ruler/compat.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/ruler/compat.go b/pkg/ruler/compat.go index 80ce675878c..862bcc54706 100644 --- a/pkg/ruler/compat.go +++ b/pkg/ruler/compat.go @@ -96,7 +96,7 @@ func (a *PusherAppender) Commit() error { _, err := a.pusher.Push(user.InjectOrgID(a.ctx, a.userID), req) if err != nil { // Don't report errors that ended with 4xx HTTP status code (series limits, duplicate samples, out of order, etc.) - if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok || resp.Code/100 != 4 { + if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok || resp.Code/100 == 5 { a.failedWrites.Inc() } } From c88103f2b92f16f7791542b5a7581b502f351488 Mon Sep 17 00:00:00 2001 From: Anand Rajagopal Date: Tue, 3 Jun 2025 22:30:00 +0000 Subject: [PATCH 2/2] Adding changelog Signed-off-by: Anand Rajagopal --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49aaedda58b..045473bd03e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,6 +50,7 @@ * [BUGFIX] Add `__markers__` tenant ID validation. #6761 * [BUGFIX] Ring: Fix nil pointer exception when token is shared. #6768 * [BUGFIX] Fix race condition in active user. #6773 +* [BUGFIX] Ruler: Prevent counting 2xx responses as failed writes. #6785 ## 1.19.0 2025-02-27