Skip to content

Commit 55c0c0a

Browse files
jackzampolinjackzampolin
authored
Release v0.33.0 to Develop
Release 0.33.0 to Develop
2 parents 4c50380 + d7fc4e9 commit 55c0c0a

File tree

3 files changed

+127
-100
lines changed

3 files changed

+127
-100
lines changed

‎CHANGELOG.md‎

Lines changed: 114 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,112 @@
11
# Changelog
22

3+
## 0.33.0
4+
5+
BREAKING CHANGES
6+
7+
* Gaia REST API
8+
* [\#3641](https://github.com/cosmos/cosmos-sdk/pull/3641) Remove the ability to use a Keybase from the REST API client:
9+
* `password` and `generate_only` have been removed from the `base_req` object
10+
* All txs that used to sign or use the Keybase now only generate the tx
11+
* `keys` routes completely removed
12+
* [\#3692](https://github.com/cosmos/cosmos-sdk/pull/3692) Update tx encoding and broadcasting endpoints:
13+
* Remove duplicate broadcasting endpoints in favor of POST @ `/txs`
14+
* The `Tx` field now accepts a `StdTx` and not raw tx bytes
15+
* Move encoding endpoint to `/txs/encode`
16+
17+
* Gaia
18+
* [\#3787](https://github.com/cosmos/cosmos-sdk/pull/3787) Fork the `x/bank` module into the Gaia application with only a
19+
modified message handler, where the modified message handler behaves the same as
20+
the standard `x/bank` message handler except for `MsgMultiSend` that must burn
21+
exactly 9 atoms and transfer 1 atom, and `MsgSend` is disabled.
22+
* [\#3789](https://github.com/cosmos/cosmos-sdk/pull/3789) Update validator creation flow:
23+
* Remove `NewMsgCreateValidatorOnBehalfOf` and corresponding business logic
24+
* Ensure the validator address equals the delegator address during
25+
`MsgCreateValidator#ValidateBasic`
26+
27+
* SDK
28+
* [\#3750](https://github.com/cosmos/cosmos-sdk/issues/3750) Track outstanding rewards per-validator instead of globally,
29+
and fix the main simulation issue, which was that slashes of
30+
re-delegations to a validator were not correctly accounted for
31+
in fee distribution when the redelegation in question had itself
32+
been slashed (from a fault committed by a different validator)
33+
in the same BeginBlock. Outstanding rewards are now available
34+
on a per-validator basis in REST.
35+
* [\#3669](https://github.com/cosmos/cosmos-sdk/pull/3669) Ensure consistency in message naming, codec registration, and JSON
36+
tags.
37+
* [\#3788](https://github.com/cosmos/cosmos-sdk/pull/3788) Change order of operations for greater accuracy when calculating delegation share token value
38+
* [\#3788](https://github.com/cosmos/cosmos-sdk/pull/3788) DecCoins.Cap -> DecCoins.Intersect
39+
* [\#3666](https://github.com/cosmos/cosmos-sdk/pull/3666) Improve coins denom validation.
40+
* [\#3751](https://github.com/cosmos/cosmos-sdk/pull/3751) Disable (temporarily) support for ED25519 account key pairs.
41+
42+
* Tendermint
43+
* [\#3804] Update to Tendermint `v0.31.0-dev0`
44+
45+
FEATURES
46+
47+
* SDK
48+
* [\#3719](https://github.com/cosmos/cosmos-sdk/issues/3719) DBBackend can now be set at compile time.
49+
Defaults: goleveldb. Supported: cleveldb.
50+
51+
IMPROVEMENTS
52+
53+
* Gaia REST API
54+
* Update the `TxResponse` type allowing for the `Logs` result to be JSON decoded automatically.
55+
56+
* Gaia CLI
57+
* [\#3653](https://github.com/cosmos/cosmos-sdk/pull/3653) Prompt user confirmation prior to signing and broadcasting a transaction.
58+
* [\#3670](https://github.com/cosmos/cosmos-sdk/pull/3670) CLI support for showing bech32 addresses in Ledger devices
59+
* [\#3711](https://github.com/cosmos/cosmos-sdk/pull/3711) Update `tx sign` to use `--from` instead of the deprecated `--name`
60+
CLI flag.
61+
* [\#3738](https://github.com/cosmos/cosmos-sdk/pull/3738) Improve multisig UX:
62+
* `gaiacli keys show -o json` now includes constituent pubkeys, respective weights and threshold
63+
* `gaiacli keys show --show-multisig` now displays constituent pubkeys, respective weights and threshold
64+
* `gaiacli tx sign --validate-signatures` now displays multisig signers with their respective weights
65+
* [\#3730](https://github.com/cosmos/cosmos-sdk/issues/3730) Improve workflow for
66+
`gaiad gentx` with offline public keys, by outputting stdtx file that needs to be signed.
67+
* [\#3761](https://github.com/cosmos/cosmos-sdk/issues/3761) Querying account related information using custom querier in auth module
68+
69+
* SDK
70+
* [\#3753](https://github.com/cosmos/cosmos-sdk/issues/3753) Remove no-longer-used governance penalty parameter
71+
* [\#3679](https://github.com/cosmos/cosmos-sdk/issues/3679) Consistent operators across Coins, DecCoins, Int, Dec
72+
replaced: Minus->Sub Plus->Add Div->Quo
73+
* [\#3665](https://github.com/cosmos/cosmos-sdk/pull/3665) Overhaul sdk.Uint type in preparation for Coins Int -> Uint migration.
74+
* [\#3691](https://github.com/cosmos/cosmos-sdk/issues/3691) Cleanup error messages
75+
* [\#3456](https://github.com/cosmos/cosmos-sdk/issues/3456) Integrate in the Int.ToDec() convenience function
76+
* [\#3300](https://github.com/cosmos/cosmos-sdk/pull/3300) Update the spec-spec, spec file reorg, and TOC updates.
77+
* [\#3694](https://github.com/cosmos/cosmos-sdk/pull/3694) Push tagged docker images on docker hub when tag is created.
78+
* [\#3716](https://github.com/cosmos/cosmos-sdk/pull/3716) Update file permissions the client keys directory and contents to `0700`.
79+
* [\#3681](https://github.com/cosmos/cosmos-sdk/issues/3681) Migrate ledger-cosmos-go from ZondaX to Cosmos organization
80+
81+
* Tendermint
82+
* [\#3699](https://github.com/cosmos/cosmos-sdk/pull/3699) Upgrade to Tendermint 0.30.1
83+
84+
BUG FIXES
85+
86+
* Gaia CLI
87+
* [\#3731](https://github.com/cosmos/cosmos-sdk/pull/3731) `keys add --interactive` bip32 passphrase regression fix
88+
* [\#3714](https://github.com/cosmos/cosmos-sdk/issues/3714) Fix USB raw access issues with gaiacli when installed via snap
89+
90+
* Gaia
91+
* [\#3777](https://github.com/cosmso/cosmos-sdk/pull/3777) `gaiad export` no longer panics when the database is empty
92+
* [\#3806](https://github.com/cosmos/cosmos-sdk/pull/3806) Properly return errors from a couple of struct Unmarshal functions
93+
94+
* SDK
95+
* [\#3728](https://github.com/cosmos/cosmos-sdk/issues/3728) Truncate decimal multiplication & division in distribution to ensure
96+
no more than the collected fees / inflation are distributed
97+
* [\#3727](https://github.com/cosmos/cosmos-sdk/issues/3727) Return on zero-length (including []byte{}) PrefixEndBytes() calls
98+
* [\#3559](https://github.com/cosmos/cosmos-sdk/issues/3559) fix occasional failing due to non-determinism in lcd test TestBonding
99+
where validator is unexpectedly slashed throwing off test calculations
100+
* [\#3411](https://github.com/cosmos/cosmos-sdk/pull/3411) Include the `RequestInitChain.Time` in the block header init during
101+
`InitChain`.
102+
* [\#3717](https://github.com/cosmos/cosmos-sdk/pull/3717) Update the vesting specification and implementation to cap deduction from
103+
`DelegatedVesting` by at most `DelegatedVesting`. This accounts for the case where
104+
the undelegation amount may exceed the original delegation amount due to
105+
truncation of undelegation tokens.
106+
* [\#3717](https://github.com/cosmos/cosmos-sdk/pull/3717) Ignore unknown proposers in allocating rewards for proposers, in case
107+
unbonding period was just 1 block and proposer was already deleted.
108+
* [\#3726](https://github.com/cosmos/cosmos-sdk/pull/3724) Cap(clip) reward to remaining coins in AllocateTokens.
109+
3110
## 0.32.0
4111

5112
BREAKING CHANGES
@@ -18,19 +125,19 @@ BREAKING CHANGES
18125
IMPROVEMENTS
19126

20127
* SDK
21-
* [\#3311] Reconcile the `DecCoin/s` API with the `Coin/s` API.
22-
* [\#3614] Add coin denom length checks to the coins constructors.
128+
* [\#3311](https://github.com/cosmos/cosmos-sdk/pull/3311) Reconcile the `DecCoin/s` API with the `Coin/s` API.
129+
* [\#3614](https://github.com/cosmos/cosmos-sdk/pull/3614) Add coin denom length checks to the coins constructors.
23130
* [\#3621](https://github.com/cosmos/cosmos-sdk/issues/3621) remove many inter-module dependancies
24-
* [\#3601] JSON-stringify the ABCI log response which includes the log and message
131+
* [\#3601](https://github.com/cosmos/cosmos-sdk/pull/3601) JSON-stringify the ABCI log response which includes the log and message
25132
index.
26-
* [\#3604] Improve SDK funds related error messages and allow for unicode in
133+
* [\#3604](https://github.com/cosmos/cosmos-sdk/pull/3604) Improve SDK funds related error messages and allow for unicode in
27134
JSON ABCI log.
28135
* [\#3620](https://github.com/cosmos/cosmos-sdk/pull/3620) Version command shows build tags
29-
* [\#3638] Add Bcrypt benchmarks & justification of security parameter choice
30-
* [\#3648] Add JSON struct tags to vesting accounts.
136+
* [\#3638](https://github.com/cosmos/cosmos-sdk/pull/3638) Add Bcrypt benchmarks & justification of security parameter choice
137+
* [\#3648](https://github.com/cosmos/cosmos-sdk/pull/3648) Add JSON struct tags to vesting accounts.
31138

32139
* Tendermint
33-
* [\#3618] Upgrade to Tendermint 0.30.03
140+
* [\#3618](https://github.com/cosmos/cosmos-sdk/pull/3618) Upgrade to Tendermint 0.30.03
34141

35142
BUG FIXES
36143

‎PENDING.md‎

Lines changed: 0 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -6,48 +6,14 @@
66

77
### Gaia REST API
88

9-
* [\#3641] Remove the ability to use a Keybase from the REST API client:
10-
* `password` and `generate_only` have been removed from the `base_req` object
11-
* All txs that used to sign or use the Keybase now only generate the tx
12-
* `keys` routes completely removed
13-
* [\#3692] Update tx encoding and broadcasting endpoints:
14-
* Remove duplicate broadcasting endpoints in favor of POST @ `/txs`
15-
* The `Tx` field now accepts a `StdTx` and not raw tx bytes
16-
* Move encoding endpoint to `/txs/encode`
17-
189
### Gaia CLI
1910

2011
### Gaia
2112

22-
* [\#3787] Fork the `x/bank` module into the Gaia application with only a
23-
modified message handler, where the modified message handler behaves the same as
24-
the standard `x/bank` message handler except for `MsgMultiSend` that must burn
25-
exactly 9 atoms and transfer 1 atom, and `MsgSend` is disabled.
26-
* [\#3789] Update validator creation flow:
27-
* Remove `NewMsgCreateValidatorOnBehalfOf` and corresponding business logic
28-
* Ensure the validator address equals the delegator address during
29-
`MsgCreateValidator#ValidateBasic`
30-
3113
### SDK
3214

33-
* \#3750 Track outstanding rewards per-validator instead of globally,
34-
and fix the main simulation issue, which was that slashes of
35-
re-delegations to a validator were not correctly accounted for
36-
in fee distribution when the redelegation in question had itself
37-
been slashed (from a fault committed by a different validator)
38-
in the same BeginBlock. Outstanding rewards are now available
39-
on a per-validator basis in REST.
40-
* [\#3669] Ensure consistency in message naming, codec registration, and JSON
41-
tags.
42-
* #3788 Change order of operations for greater accuracy when calculating delegation share token value
43-
* #3788 DecCoins.Cap -> DecCoins.Intersect
44-
* [\#3666] Improve coins denom validation.
45-
* [\#3751] Disable (temporarily) support for ED25519 account key pairs.
46-
4715
### Tendermint
4816

49-
* [\#3804] Update to Tendermint `v0.31.0-dev0`
50-
5117
<!--------------------------------- FEATURES --------------------------------->
5218

5319
## FEATURES
@@ -60,9 +26,6 @@ tags.
6026

6127
### SDK
6228

63-
* [\#3719](https://github.com/cosmos/cosmos-sdk/issues/3719) DBBackend can now be set at compile time.
64-
Defaults: goleveldb. Supported: cleveldb.
65-
6629
### Tendermint
6730

6831
<!------------------------------- IMPROVEMENTS ------------------------------->
@@ -71,42 +34,14 @@ tags.
7134

7235
### Gaia REST API
7336

74-
* Update the `TxResponse` type allowing for the `Logs` result to be JSON
75-
decoded automatically.
76-
7737
### Gaia CLI
7838

79-
* [\#3653] Prompt user confirmation prior to signing and broadcasting a transaction.
80-
* [\#3670] CLI support for showing bech32 addresses in Ledger devices
81-
* [\#3711] Update `tx sign` to use `--from` instead of the deprecated `--name`
82-
CLI flag.
83-
* [\#3738] Improve multisig UX:
84-
* `gaiacli keys show -o json` now includes constituent pubkeys, respective weights and threshold
85-
* `gaiacli keys show --show-multisig` now displays constituent pubkeys, respective weights and threshold
86-
* `gaiacli tx sign --validate-signatures` now displays multisig signers with their respective weights
87-
* [\#3730](https://github.com/cosmos/cosmos-sdk/issues/3730) Improve workflow for
88-
`gaiad gentx` with offline public keys, by outputting stdtx file that needs to be signed.
89-
* [\#3761](https://github.com/cosmos/cosmos-sdk/issues/3761) Querying account related information using custom querier in auth module
90-
9139
### Gaia
9240

9341
### SDK
9442

95-
* \#3753 Remove no-longer-used governance penalty parameter
96-
* \#3679 Consistent operators across Coins, DecCoins, Int, Dec
97-
replaced: Minus->Sub Plus->Add Div->Quo
98-
* [\#3665] Overhaul sdk.Uint type in preparation for Coins Int -> Uint migration.
99-
* \#3691 Cleanup error messages
100-
* \#3456 Integrate in the Int.ToDec() convenience function
101-
* [\#3300] Update the spec-spec, spec file reorg, and TOC updates.
102-
* [\#3694] Push tagged docker images on docker hub when tag is created.
103-
* [\#3716] Update file permissions the client keys directory and contents to `0700`.
104-
* [\#3681](https://github.com/cosmos/cosmos-sdk/issues/3681) Migrate ledger-cosmos-go from ZondaX to Cosmos organization
105-
10643
### Tendermint
10744

108-
* [\#3699] Upgrade to Tendermint 0.30.1
109-
11045
<!--------------------------------- BUG FIXES -------------------------------->
11146

11247
## BUG FIXES
@@ -115,29 +50,8 @@ CLI flag.
11550

11651
### Gaia CLI
11752

118-
* [\#3731](https://github.com/cosmos/cosmos-sdk/pull/3731) `keys add --interactive` bip32 passphrase regression fix
119-
* [\#3714](https://github.com/cosmos/cosmos-sdk/issues/3714) Fix USB raw access issues with gaiacli when installed via snap
120-
12153
### Gaia
12254

123-
* [\#3777](https://github.com/cosmso/cosmos-sdk/pull/3777) `gaiad export` no longer panics when the database is empty
124-
* [\#3806](https://github.com/cosmos/cosmos-sdk/pull/3806) Properly return errors from a couple of struct Unmarshal functions
125-
12655
### SDK
12756

128-
* \#3728 Truncate decimal multiplication & division in distribution to ensure
129-
no more than the collected fees / inflation are distributed
130-
* \#3727 Return on zero-length (including []byte{}) PrefixEndBytes() calls
131-
* \#3559 fix occasional failing due to non-determinism in lcd test TestBonding
132-
where validator is unexpectedly slashed throwing off test calculations
133-
* [\#3411] Include the `RequestInitChain.Time` in the block header init during
134-
`InitChain`.
135-
* [\#3717] Update the vesting specification and implementation to cap deduction from
136-
`DelegatedVesting` by at most `DelegatedVesting`. This accounts for the case where
137-
the undelegation amount may exceed the original delegation amount due to
138-
truncation of undelegation tokens.
139-
* [\#3717] Ignore unknown proposers in allocating rewards for proposers, in case
140-
unbonding period was just 1 block and proposer was already deleted.
141-
* [\#3726] Cap(clip) reward to remaining coins in AllocateTokens.
142-
14357
### Tendermint

‎x/distribution/simulation/invariants.go‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,24 +59,30 @@ func CanWithdrawInvariant(k distr.Keeper, sk types.StakingKeeper) sdk.Invariant
5959

6060
var remaining sdk.DecCoins
6161

62+
valDelegationAddrs := make(map[string][]sdk.AccAddress)
63+
for _, del := range sk.GetAllSDKDelegations(ctx) {
64+
valAddr := del.GetValidatorAddr().String()
65+
valDelegationAddrs[valAddr] = append(valDelegationAddrs[valAddr], del.GetDelegatorAddr())
66+
}
67+
6268
// iterate over all validators
6369
sk.IterateValidators(ctx, func(_ int64, val sdk.Validator) (stop bool) {
6470
_ = k.WithdrawValidatorCommission(ctx, val.GetOperator())
65-
// TODO fetch delegations just for the validator, requires sdk.ValidatorSet change
66-
// iterate over all current delegations, withdraw rewards
67-
dels := sk.GetAllSDKDelegations(ctx)
68-
for _, delegation := range dels {
69-
if delegation.GetValidatorAddr().String() == val.GetOperator().String() {
70-
err := k.WithdrawDelegationRewards(ctx, delegation.GetDelegatorAddr(), delegation.GetValidatorAddr())
71-
if err != nil {
71+
72+
delegationAddrs, ok := valDelegationAddrs[val.GetOperator().String()]
73+
if ok {
74+
for _, delAddr := range delegationAddrs {
75+
if err := k.WithdrawDelegationRewards(ctx, delAddr, val.GetOperator()); err != nil {
7276
panic(err)
7377
}
7478
}
7579
}
80+
7681
remaining = k.GetValidatorOutstandingRewards(ctx, val.GetOperator())
7782
if len(remaining) > 0 && remaining[0].Amount.LT(sdk.ZeroDec()) {
7883
return true
7984
}
85+
8086
return false
8187
})
8288

0 commit comments

Comments
 (0)