Merge PR #3808: Make cli tests use build files

jaekwon · jackzampolin · commit a24dee015599 · 2019-03-07T11:51:14.000-08:00
* Make cli tests use build files

* Update PENDING.md

Add PR number.
diff --git a/Makefile b/Makefile
@@ -160,8 +160,8 @@ godocs:
 
 test: test_unit
 
-test_cli:
-	@go test -p 4 `go list github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test` -tags=cli_test
+test_cli: build
+	@go test -p 4 `go list ./cmd/gaia/cli_test/...` -tags=cli_test
 
 test_ledger:
     # First test with mock
diff --git a/PENDING.md b/PENDING.md
@@ -38,6 +38,8 @@
 
 ### Gaia
 
+* #3808 `gaiad` and `gaiacli` integration tests use ./build/ binaries.
+
 ### SDK
 
 ### Tendermint
diff --git a/client/lcd/test_helpers.go b/client/lcd/test_helpers.go
@@ -668,7 +668,7 @@ func doTransfer(
 	resp, body, recvAddr := doTransferWithGas(
 		t, port, seed, name, memo, pwd, addr, "", 1.0, false, true, fees,
 	)
-	require.Equal(t, http.StatusOK, resp.StatusCode, resp)
+	require.Equal(t, http.StatusOK, resp.StatusCode, body)
 
 	var txResp sdk.TxResponse
 	err := cdc.UnmarshalJSON([]byte(body), &txResp)
diff --git a/cmd/gaia/cli_test/test_helpers.go b/cmd/gaia/cli_test/test_helpers.go

Original file line number	Diff line number	Diff line change
`@@ -668,7 +668,7 @@ func doTransfer(`
`668`	`668`	`resp, body, recvAddr := doTransferWithGas(`
`669`	`669`	`t, port, seed, name, memo, pwd, addr, "", 1.0, false, true, fees,`
`670`	`670`	`)`
`671`		`- require.Equal(t, http.StatusOK, resp.StatusCode, resp)`
	`671`	`+ require.Equal(t, http.StatusOK, resp.StatusCode, body)`
`672`	`672`
`673`	`673`	`var txResp sdk.TxResponse`
`674`	`674`	`err := cdc.UnmarshalJSON([]byte(body), &txResp)`