Skip to content

Commit bb1fd58

Browse files
committed
Address @alexanderbez comments
1 parent d21ab4e commit bb1fd58

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

crypto/keys/mintkey/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ The present Bcrypt security parameter used is 12, which should take about a quar
55

66
For some background into security parameter considerations, see [here](https://auth0.com/blog/hashing-in-action-understanding-bcrypt/) and [here](https://security.stackexchange.com/questions/3959/recommended-of-iterations-when-using-pkbdf2-sha256/3993#3993).
77

8-
Given our security model, where an attacker would need to already have access to a victim's computer and copy the `~/.gaiacli` directory (as opposed to e.g. web authentication), this parameter choice seems sufficient for the time being.
8+
Given our security model, where an attacker would need to already have access to a victim's computer and copy the `~/.gaiacli` directory (as opposed to e.g. web authentication), this parameter choice seems sufficient for the time being. Bcrypt always generates a 448-bit key, so the security in practice is determined by the length & complexity of a user's password and the time taken to generate a Bcrypt key from their password (which we can choose with the security parameter). Users would be well-advised to use difficult-to-guess passwords.
99

1010
Benchmarking
1111
------------
1212

1313
To run Bcrypt benchmarks:
1414

1515
```bash
16-
go test -bench .
16+
go test -v --bench github.com/cosmos/cosmos-sdk/crypto/keys/mintkey
1717
```
1818

1919
On the test machine (midrange ThinkPad; i7 6600U), this results in:

0 commit comments

Comments
 (0)