R4R: Fix the bug in GetAccount when len(res) == 0 and err == nil#3141
Merged
cwgoes merged 3 commits intocosmos:developfrom Dec 21, 2018
Merged
R4R: Fix the bug in GetAccount when len(res) == 0 and err == nil#3141cwgoes merged 3 commits intocosmos:developfrom
cwgoes merged 3 commits intocosmos:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
- Coverage 55.03% 55.01% -0.03%
===========================================
Files 133 133
Lines 9434 9434
===========================================
- Hits 5192 5190 -2
- Misses 3925 3927 +2
Partials 317 317 |
Codecov Report
@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
+ Coverage 54.82% 54.84% +0.02%
===========================================
Files 133 133
Lines 9552 9548 -4
===========================================
Hits 5237 5237
+ Misses 3994 3990 -4
Partials 321 321 |
alexanderbez
suggested changes
Dec 18, 2018
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Thanks @MrXJC -- the fix looks good. Mind adding a pending log entry?
Contributor
Author
|
Sorry, I was so late to add the pending log entry. @alexanderbez |
alexanderbez
approved these changes
Dec 21, 2018
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
LGTM, thanks @MrXJC 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: