R4R: Round down when calculating rewards (fixes F1 sim bug)#3359
Merged
cwgoes merged 4 commits intojack/makefile-fixfrom Jan 23, 2019
Merged
R4R: Round down when calculating rewards (fixes F1 sim bug)#3359cwgoes merged 4 commits intojack/makefile-fixfrom
cwgoes merged 4 commits intojack/makefile-fixfrom
Conversation
rigelrozanski
approved these changes
Jan 23, 2019
Codecov Report
@@ Coverage Diff @@
## jack/makefile-fix #3359 +/- ##
====================================================
- Coverage 54.93% 54.9% -0.03%
====================================================
Files 132 132
Lines 9645 9645
====================================================
- Hits 5298 5296 -2
- Misses 4014 4016 +2
Partials 333 333 |
e2813fc to
e52e793
Compare
alexanderbez
approved these changes
Jan 23, 2019
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3354
Always round down when calculating rewards in F1 fee distribution. As far as I can tell, this fixes all the F1-related simulation issues, but I haven't yet run a long multi-seed test.
Wrote testsUpdated relevant documentation (docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: