R4R: various: code clean up, refactoring#3580
Merged
jackzampolin merged 23 commits intodevelopfrom Feb 14, 2019
Merged
Conversation
added 2 commits
February 9, 2019 21:30
This heavy-weight refactoring sprang from an attempt of removing a duplicate PostProcessResponse() function located in client/keys/utils.go that turned out to be undoable without introducing import cycles. Thus I moved all x/ modules-agnostic HTTP/REST basic request and response types and convenience functions into a new cosmos-sdk/types/rest standalone package. The cosmos-sdk/client/rest package retains the txs handling functions that depend on CLIContext and TxBuilder provided by client/context and x/auth/client/txbuilder respectively.
alessio
requested review from
alexanderbez,
jackzampolin,
jleni and
sunnya97
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Disallow empty denoms.
alessio
force-pushed
the
alessio/rest-types-refactoring
branch
from
edd81ba to
0d176a6
Compare
alessio
commented
Feb 10, 2019
types/rest/rest.go
Outdated
| } | ||
|
|
||
| // UnjailReq request unjailing | ||
| type UnjailReq struct { |
Contributor
Author
There was a problem hiding this comment.
I moved all requests into this package
Contributor
There was a problem hiding this comment.
imho I don't think we should be doing this -- but I need to think on this some more after some coffee.
Contributor
There was a problem hiding this comment.
Agree with @alexanderbez here. I think each client/rest package should also have a types that exports the structs to call the endpoints.
Codecov Report
@@ Coverage Diff @@
## develop #3580 +/- ##
===========================================
- Coverage 60.92% 60.82% -0.11%
===========================================
Files 188 189 +1
Lines 14084 14170 +86
===========================================
+ Hits 8581 8619 +38
- Misses 4959 5007 +48
Partials 544 544 |
alessio
changed the title
Contributor
|
Fails the linter at present. |
alexanderbez
suggested changes
Feb 11, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Thanks @alessio. I left a few minor remarks. In addition, I don't think any of the coins stuff belongs here.
alexanderbez
approved these changes
Feb 13, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
It looks like types were just moved out of client/rest/types.go to types/rest/rest.go.
added 2 commits
February 13, 2019 15:59
Contributor
5 tasks
…smos-sdk into alessio/rest-types-refactoring
jackzampolin
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client/rest: code cleanup and refactoring.
This heavy-weight refactoring sprang from an attempt of removing a duplicate PostProcessResponse() function located in client/keys/utils.go that turned out to be undoable without introducing import cycles. Thus I moved all x/modules-agnostic HTTP/REST basic request and response types and convenience functions into a new cosmos-sdk/types/rest standalone package.
The cosmos-sdk/client/rest package retains the txs handling functions that depend on CLIContext and TxBuilder provided by client/context and x/auth/client/txbuilder respectively.
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: